Bug 222896

Summary:	installation shouldn't ask for confirmation after online update triggered YaST restart
Product:	[openSUSE] openSUSE 10.2	Reporter:	Jiří Suchomel <jsuchome>
Component:	YaST2	Assignee:	Lukas Ocilka <locilka>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Critical
Priority:	P5 - None	CC:	aj, meissner
Version:	Beta 2 plus
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	y2logs Proposed patch

Description Jiří Suchomel 2006-11-21 09:33:34 UTC

After I installed libzypp patch during installation, YaST said it will restart: "Packages for package management were updated.
Finishing and restarting now." (=> this is known restart, no crash). 

When YaST started again, popup with text "The previous installation has failed.
Would you like it to continue?" appeared.

This popup should not appear in this special case, as nothing failed and the restart was actually called by yast itself. And it doesn't have sense to do not confirm the popup anyway. The restart is invoked by returning `restart_same_step from inst_you, which AFAIK creates restart_data_file, so I hope you should be able to distinguish this situation from others.

Comment 1 Lukas Ocilka 2006-11-21 10:07:20 UTC

Andreas, I feel this is important and I'd like to fix it. Please, what do you think of that? It should not take much time...

Comment 2 Jiří Suchomel 2006-11-21 10:11:28 UTC

Similar (but kind of different) problem is after installing kernel update. In the above case I think the popup should not be shown at all. With the kernel case the system is rebooted, so it might have sense to show popup, but it is confusing that popup says that installation has failed, which of course is not true.

I think that also for such kind of reboot the popup is not needed (as user was informed about reboot), but maybe different text would help (I know that it's far too late for new texts now).

Comment 3 Jiří Suchomel 2006-11-21 10:13:10 UTC

Created attachment 106362 [details]
y2logs

Note that the logs contain both situations - first libzypp patch was installed and YaST restarted, than kernel patch was installed and reboot followed.

Comment 4 Lukas Ocilka 2006-11-21 10:15:22 UTC

Of course, this is just "another" kind of restarting YaST on purpose... it's in the very same place...

Comment 5 Lukas Ocilka 2006-11-21 10:32:01 UTC

I'm just testing this change if everything works as expected.

Comment 6 Lukas Ocilka 2006-11-21 10:37:20 UTC

Created attachment 106370 [details]
Proposed patch

All return codes (ret == `reboot || ret == `restart_yast || ret == `restart_same_step) are handled...

Comment 7 Andreas Jaeger 2006-11-21 12:58:08 UTC

Please fix and submit today.

Comment 8 Lukas Ocilka 2006-11-21 13:47:15 UTC

- Reporting the failed or aborted installation only when it has
  been really aborted or when it really failed. YaST or system
  restarts on purpose (online update) are now handled correctly -
  there is no question whether user wants to continue with
  the installation (#222896).
- 2.14.13

Comment 9 Jiří Suchomel 2006-11-23 13:17:54 UTC

*** Bug 223439 has been marked as a duplicate of this bug. ***