Bug 223872

Summary:	correct board_chrp matching for pegasos
Product:	[openSUSE] openSUSE 10.2	Reporter:	Olaf Hering <ohering>
Component:	YaST2	Assignee:	Jiri Srain <jsrain>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Major
Priority:	P5 - None
Version:	RC 2
Target Milestone:	---
Hardware:	PowerPC
OS:	Linux
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	prep-pegasos.patch

Description Olaf Hering 2006-11-27 14:01:51 UTC

10.2rc2

major screwup on my side.
yast2/library/modules/Arch.ycp:board_compatible()

Read(.probe.system) does return system:'CHRP' even for pegasos.
As a result, _board_compatible will become "CHRP", not nil. The new code will not run in this case. 

_board_compatible must be "Pegasos" on exit, not "CHRP".
Will add a patch.

Comment 1 Olaf Hering 2006-11-27 14:21:55 UTC

argh, there is also a backslash n in the string.

2006-11-27 14:18:29 <1> 10.10.101.89(2922) [YCP] Arch.ycp:233 model $["exit":0, "stderr":"", "stdout":"Pegasos2\n"] , device_type $["exit":0, "stderr":"", "stdout":"chrp\n"]

Comment 2 Olaf Hering 2006-11-27 14:48:43 UTC

Created attachment 107041 [details]
prep-pegasos.patch

remove trailing newline by using echo -n

remove else case to always run board== check

Comment 3 Jiri Srain 2006-11-27 15:53:44 UTC

Andreas, this is "only" major, OK for RC3?

Comment 4 Andreas Jaeger 2006-11-27 17:06:14 UTC

Ok.

Comment 5 Jiri Srain 2006-11-29 12:29:52 UTC

Forgot to close this bug, fixed for RC3.