Bug 224401

Summary:	script patch is shown as "All dependencies satisfied" although it is not installed
Product:	[openSUSE] openSUSE 10.2	Reporter:	Andreas Hanke <andreas.hanke>
Component:	libzypp	Assignee:	Stefan Schubert <schubi>
Status:	RESOLVED FIXED	QA Contact:	Klaus Kämpf <kkaempf>
Severity:	Minor
Priority:	P5 - None
Version:	RC 2
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	Screenshot YaST2 logfiles

Description Andreas Hanke 2006-11-29 08:38:28 UTC

There is a glitch with the improved patch selector:

Patches that include packages are correctly shown as "All dependencies satisfied" if the needed packages are installed, but the fetchmsttfonts script patch is shown as "All dependencies satisfied" even though it seems to be illogial because there are no package dependencies that could be satisfied and the script is definitely _not_ installed (and therefore not satisfied).

Comment 1 Andreas Hanke 2006-11-29 08:39:12 UTC

Created attachment 107332 [details]
Screenshot

Comment 2 Andreas Hanke 2006-11-29 08:48:53 UTC

Created attachment 107336 [details]
YaST2 logfiles

Comment 3 Stefan Hundhammer 2006-11-29 10:40:10 UTC

Probably that zypp::ResStatus::isSatisfied() flag should not be set in that case: If it is a patch that does not have any packages, only scripts and/or messages.

Comment 4 Klaus Kämpf 2006-11-29 10:48:36 UTC

The script is not installed, thats right. So for 'script resolvables', installed means 'has been run'.

Stefan, please check the logfiles

Comment 5 Stefan Schubert 2006-11-29 13:16:22 UTC

[script]fetchmsttfonts.sh is satisfied cause his requirement is fulfilled.
(freshens [package] (namedcap) glibc; ResolverContext::requirementIsMet([package] (namedcap) glibc) Y)
....
itemIsPresent(<US_s_>U__s_[S2:0][script]fetchmsttfonts.sh-2302-patch-fetchmsttfonts.sh-2-2302-1.noarch) Y ---> all requirements of U__s_[S2:0][patch]fetchmsttfonts.sh-2302-0.noarch met -> satisfied

scripts have no atoms in order to define a relation with the patch.

Comment 6 Andreas Hanke 2006-12-02 11:34:20 UTC

This behaviour has the side-effect that opensuse-updater doesn't show the patch at all.

zypper says:

20061129-092444 | fetchmsttfonts.sh | 2302-0 | optional | Not Needed

And opensuse-updater doesn't say anything at all. I guess it hides all patches which are marked as not needed.

Comment 9 Andreas Hanke 2007-01-26 15:44:58 UTC

Actually I cannot follow.

How can this be a duplicate of bug 192535 if it has been found two months after bug 192535 has been fixed?

The problem here is not that the script doesn't get run if I install it, the problem is that YOU doesn't even show it in the default view. Running the script is not a problem at all, it works if the patch is selected manually (which requires the user to switch to the "include non-needed patches view).

Comment 10 Stefan Schubert 2007-01-26 16:03:17 UTC

Ahh, thanks. Yes that's true. ---> reopen.

Comment 14 Stefan Schubert 2008-04-25 14:07:15 UTC

We will not have sripts and atoms in patches anymore for 11.0. So this bug
is outdated.