Bug 233016

Summary: scribus-1.3.3.4-32: comparison with string literal
Product: [openSUSE] openSUSE 10.3 Reporter: David Binderman <dcb314>
Component: X11 ApplicationsAssignee: Stanislav Brabec <sbrabec>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SUSE Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2007-01-09 22:32:43 UTC
I just tried to compile package scribus-1.3.3.4-32

The compiler said

colorm.cpp:200: warning: comparison with string literal

The source code is

        if (name == "")

I agree with the compiler. Suggest new code

        if (name[ 0] == 0)
Comment 1 Stephan Binner 2007-01-10 07:43:32 UTC
You have a strange definition of "base system". ;-)
Comment 2 Stephan Binner 2007-01-10 09:10:43 UTC
Maybe this gets already fixed with an update to 1.3.3.7? :-)
Comment 3 Stefan Dirsch 2007-01-16 22:30:37 UTC
Feel free to close as duplicate of Bug #233655.
Comment 4 P Linnell 2007-02-21 22:56:57 UTC
I can recommend closing this as we will release 1.3.3.8 very very soon and I was able to install and build both 1.3.3.x (stable) and 1.3.4(devel) branches with GCC 4.2 on Suse 10.2. 

I forced -Wstring-literal-comparison into our build and we nuked a pile of these warnings along with some others which gcc 4.2 flags. 
Comment 5 Petr Gajdos 2007-03-08 14:46:40 UTC

*** This bug has been marked as a duplicate of bug 233655 ***