Bug 239954

Summary: simh-3.3_1-38: array subscript is above array bounds
Product: [openSUSE] openSUSE 10.3 Reporter: David Binderman <dcb314>
Component: OtherAssignee: Klaus Kämpf <kkaempf>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SUSE Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2007-01-29 19:02:54 UTC
I just tried to compile package simh-3.3_1-38
with the new GNU compiler version 4.3 snapshot 20070126

The compiler said

ALTAIR/altair_dsk.c:333: warning: array subscript is above array bounds

The source code is

        if (cur_byte[cur_disk] > 136) {
                i = cur_byte[cur_disk];
                dskbuf[i] = data & 0xFF;

but

char dskbuf[137];       /* Data Buffer */

Suggest code rework.
Comment 1 Stefan Dirsch 2007-01-31 22:40:48 UTC
Feel free to close as duplicate of Bug #240922.
Comment 2 Klaus Kämpf 2007-02-02 09:19:49 UTC

*** This bug has been marked as a duplicate of bug 240922 ***