Bug 240891

Summary: xlockmore-5.23-21: array subscript is above array bounds
Product: [openSUSE] openSUSE 10.3 Reporter: David Binderman <dcb314>
Component: X11 ApplicationsAssignee: E-mail List <bnc-team-screening>
Status: RESOLVED DUPLICATE QA Contact: Stefan Dirsch <sndirsch>
Severity: Normal    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SUSE Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2007-01-31 21:20:08 UTC 
I just tried to compile package xlockmore-5.23-21
with the new GNU compiler version 4.3 snapshot 20070126

The compiler said

solitare.cc:1229: warning: array subscript is above array bounds

The source code is

        for (pile = 0; pile < MAXPILES; pile++)
                if (alternatePiles[pile]->canTake(card))

but

        CardPile * alternatePiles[MAXALTERNATEPILES];

#define MAXSUITS 4
#define MAXALTERNATEPILES 7
#define MAXPILES (MAXALTERNATEPILES+MAXSUITS+2)

Suggest code rework.
Comment 1 Stefan Dirsch 2007-01-31 22:12:33 UTC 

*** This bug has been marked as a duplicate of bug 240922 ***