|
Bugzilla – Full Text Bug Listing |
| Summary: | yast2-testsuite - When running YaST testsuite, Mode::testsuite() returns false | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 10.3 | Reporter: | Lukas Ocilka <locilka> |
| Component: | YaST2 | Assignee: | Martin Vidner <mvidner> |
| Status: | RESOLVED FIXED | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Normal | ||
| Priority: | P3 - Medium | CC: | jsrain, jsuchome, msvec, mvidner |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | Other | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: |
mode-testsuite.diff
y2modetest.diff |
||
|
Description
Lukas Ocilka
2007-02-08 16:57:05 UTC
Created attachment 118289 [details]
mode-testsuite.diff
Please test this patch.
Yes, it seems to work correctly. Please release it, thanks for the help. Ah, sorry, I forgot to close the bug -- already in STABLE :) The fix breaks usage of Mode::test() in command-line mode (UI is always initialized). Any chance of having a different check for "testsuite" mode, other than an UI:: call? See also bug 374259. Now this is causing problems with WebYaST: there is no UI so Mode::testsuite is set. I think the UI check should be reverted. If you think so ... Any news? Should I explicitely set mode to commandline in YaPI or is proper solution near? poinggggg! The proper solution is to deprecate Mode::test(). If you need it for WebYaST, then it is probably too risky for SP1 to revert the patch from comment 1. Consider making your code independent of Mode::test, or indeed resetting the mode in a webyast yapi call to have another hack join the party. *** Bug 582578 has been marked as a duplicate of this bug. *** (In reply to comment #10) > Consider making your code independent of Mode::test, Seems to be risky for SP1 as well, if I'd not want to remove most of testsuites. > or indeed resetting the > mode in a webyast yapi call to have another hack join the party. One more hack, and making YaPI untestable... Created attachment 347263 [details]
y2modetest.diff
Actually the current situation (where Mode::test continues to exist) can be fixed by checking an environment variable that is set in the test harness, such as Y2ALLGLOBAL.
Please try it out.
(In reply to comment #13) > Created an attachment (id=347263) [details] > y2modetest.diff > > Actually the current situation (where Mode::test continues to exist) can be > fixed by checking an environment variable that is set in the test harness, such > as Y2ALLGLOBAL. > > Please try it out. Testsuite works (tested: users, firewall) = mode testsuite set correctly YaPI works (for users) = mode testsuite not set SP1: http://svn.opensuse.org/viewvc/yast?view=revision&revision=61234 osc -A https://api.suse.de rq show 5250 11.2: http://svn.opensuse.org/viewvc/yast?view=revision&revision=61235 2.18.31 submitted to YaST:Web:11.2 trunk: http://svn.opensuse.org/viewvc/yast?view=revision&revision=61235 (no Factory submission yet) |