Bug 255758

Summary: inst_rpmcopy uses obsolete Pkg::SourceProduct which does just nothing
Product: [openSUSE] openSUSE 11.0 Reporter: Lukas Ocilka <locilka>
Component: YaST2Assignee: Ladislav Slezák <lslezak>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None    
Version: Alpha 2   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Lukas Ocilka 2007-03-19 11:20:07 UTC
This might be a lost feature about caching sources, but it also might be supported internally in ZYPP.

this is the part of the code:

integer CachedSourceId () {
  integer cached_id = -1;
  foreach (integer id, Packages::theSources, {
    map<string,string> product_data = (map<string,string>)Pkg::SourceProduct (id);
    y2milestone ("Id %1: SourceProduct %2", id, product_data);
    ...
  }
  ...
}

clients/inst_rpmcopy.ycp:115 Pkg Builtin called: SourceProduct
Source.cc(SourceProduct):672 Pkg::SourceProduct() is obsoleted, use Pkg::SourceProductData() instead!
clients/inst_rpmcopy.ycp:116 Id 1: SourceProduct $[]
clients/inst_rpmcopy.ycp:124 Detected cached source ID: -1

It searches for product_data["flags"] but there is no such "flags" because the returned map is always empty. Suggested Pkg::SourceProductData doesn't have that key either.
Comment 1 Lukas Ocilka 2007-09-12 16:52:06 UTC
It seems this is not gonna be fixed for 10.3 ---> LATER
Comment 2 Stephan Kulow 2008-06-25 09:10:38 UTC
mass reopening of later+remind bugs of 11.0
Comment 3 Ladislav Slezák 2008-09-17 10:05:59 UTC
The caching is now handled in libzypp (see https://bugzilla.novell.com/show_bug.cgi?id=362003#c4 for some details).

I just removed all the obsoleted code.
Comment 4 Ladislav Slezák 2008-09-17 11:51:45 UTC
Fixed in yast2-packager-2.17.16.