Bug 259493

Summary: Yast should display the free space warning only when something is going to be installed there
Product: [openSUSE] openSUSE 11.1 Reporter: Felix Miata <mrmazda>
Component: InstallationAssignee: Ladislav Slezák <lslezak>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Enhancement    
Priority: P3 - Medium    
Version: Factory   
Target Milestone: ---   
Hardware: PC   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on: 333166    
Bug Blocks:    
Attachments: y2logs

Description Felix Miata 2007-03-30 21:32:20 UTC
I normally do a custom partitioning setup for every install. FAT partitions for today's http install of factory were hda3, hda8 & hda9 set during partitioning to mount on /disks/C, /disks/D and /disks/E. As long as the installer finds it necessary to show in red that these partitions (which are irrelevant to the installation of a SUSE operating system) have virtually no freespace, it should label them as specified during partitioning, and not arbitrarily label them windows/C, windows/D and windows/E, which is what it did. Only one of them is a windoz partition anyway. The others are DOS and OS/2.
Comment 1 Felix Miata 2007-03-30 22:18:37 UTC
After filing this originally and proceeding a bit further I realized the installer doesn't know how to display the correct sizes for the / partition. My installation target / is 4.8G. The installer was telling me it was 7.xG, grossly over reporting the amount of projected freespace. Relevant portion of fstab:

/dev/hda3 on /disks/C .25G msdos
/dev/hda5 on /disks/hda/boot .1G ext2
/dev/hda6 on swap
/dev/hda7 on /disks/hda/suse 4.8G ext3
/dev/hda8 on /disks/D 3G vfat
/dev/hda9 on /disks/E .25G msdos
/dev/hda14 on /disks/hda/knoppix 2.7G ext3
/dev/hda15 on /home 1.6G ext3
/dev/hda16 on /pub 7G ext3
/dev/hda17 on /srv .12G ext3
/dev/hda18 on /usr/local 1G ext3
/dev/hda19 on / 4.8G ext3
/dev/sda5 on /disks/sda/boot .07G ext2
/dev/sda6 on swap
/dev/sda7 on /disks/sda/cooker 5G ext3
/dev/sda8 on /disks/sda/home 1.6G ext3
Comment 2 Cyril Hrubis 2007-04-03 17:30:02 UTC
Please attach y2logs from this installation. If you are in doubt follow:

http://en.opensuse.org/Bugs/YaST

Thanks!
Comment 3 Felix Miata 2007-04-03 23:23:48 UTC
Created attachment 128746 [details]
y2logs
Comment 4 Thomas Fehr 2007-04-04 14:39:26 UTC
Space calculation is part of yast2-packager, not yast2-storage.
Comment 5 Ladislav Slezák 2007-04-06 13:45:50 UTC
OK, Yast should display the free space warning only when something is going to be installed there.

AFAIK /windows/* doesn't mean that there is any OS installed, /windows/C means that the partition is seen as disk C: in MS Windows.

The log says:  $["create":true, "detected_fs":`ext3, "device":"/dev/hda26", "format":true, "fs_options":$["opt_dir_index":$["
option_str":"-O dir_index", "option_value":true]], "fsid":131, "fstopt":"acl,user_xattr", "fstype":"Linux native", "inactive":t
rue, "mkfs_opt":"-O dir_index", "mount":"/", "mountby":`id, "name":"hda26", "nr":26, "region":[4134, 938], "size_k":7534485, "t
ype":`logical, "udev_id":["ata-ST360015A_5KB0MASE-part26"]

So there was 7GB partition (/dev/hda26) for /, it was later changed to /dev/hda19:

$["detected_fs":`ext3, "device":"/dev/hda19"
, "format":true, "fs_options":$["opt_dir_index":$["option_str":"-O dir_index", "option_value":true]], "fsid":131, "fstopt":"noa
time,acl,user_xattr", "fstype":"Linux native", "inactive":true, "label":"hdx19factory", "mkfs_opt":"-O dir_index", "mount":"/",
 "mountby":`label, "name":"hda19", "nr":19, "region":[3509, 625], "size_k":5020281, "type":`logical, "udev_id":["ata-ST360015A_
5KB0MASE-part19"]

which has ~5GB. The proposal code says

/: [5015161, 0, 2275196, 0]

which means ~5GB total, 0 used now, 2.2GB used after installation. No problem here.
Comment 6 Felix Miata 2007-04-06 14:50:37 UTC
(In reply to comment #5)
> which has ~5GB. The proposal code says
 
> /: [5015161, 0, 2275196, 0]
 
> which means ~5GB total, 0 used now, 2.2GB used after installation. No problem
> here.

That's what I expected to see when it was telling me the partition was 7G+ total, and why I added comment 1. 

Comment 7 Lukas Ocilka 2007-09-10 15:30:56 UTC
Old label:
installation disk usage report should be smarter
New label:
Yast should display the free space warning only when something is going to be installed there

Enhancement, LATER ---> after 10.3
Comment 8 Felix Miata 2008-02-26 15:35:42 UTC
It's now well past 10.3
Comment 9 Ladislav Slezák 2008-02-26 15:59:14 UTC
Well, you are right, but I have more severe bugs so this is still LATER... :-(

(BTW see bug #333166, it is related to this bug a little bit and I just have fixed it.)
Comment 10 Felix Miata 2008-08-06 18:42:06 UTC
Hopefully 11.1 can include this.
Comment 11 Ladislav Slezák 2008-12-30 12:36:35 UTC
Fixed in Yast SVN trunk (for openSUSE 11.2)
Comment 12 Ladislav Slezák 2009-01-13 13:58:50 UTC
Submitted in yast2-packager-2.18.0. (openSUSE-11.2)