Bug 276650

Summary:	yast2 bluetooth module needs adaptation for bluez-3.10
Product:	[openSUSE] openSUSE 10.3	Reporter:	Forgotten User ZhJd0F0L3x <forgotten_ZhJd0F0L3x>
Component:	YaST2	Assignee:	Ladislav Slezák <lslezak>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	behlert
Version:	Alpha 4
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Component Test	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	diff against yast2-bluetooth-2.15.1.tar.bz2

Description Forgotten User ZhJd0F0L3x 2007-05-21 16:57:05 UTC

Hi,

with bluez-3.10, the sdp daemon is no longer standalone, but built into hcid.
It is activated with a special option "-s" to hcid.

So instead of writing "SDP_START=yes", we need to change HCI_DAEMON_ARGS to "-s $HCI_DAEMON_ARGS"

I'll attach a proof-of-concept patch for src/Bluetooth.ycp

Comment 1 Forgotten User ZhJd0F0L3x 2007-05-21 16:58:26 UTC

Created attachment 141297 [details]
diff against yast2-bluetooth-2.15.1.tar.bz2

Comment 2 Ladislav Slezák 2007-05-23 09:01:39 UTC

The patch has been applied in yast2-bluetooth-2.15.2
(Thank you very much for the patch!)

BTW, I suppose that the change during package update is handled by bluez themselves...

Comment 3 Forgotten User ZhJd0F0L3x 2007-05-23 13:51:44 UTC

(In reply to comment #2)
> The patch has been applied in yast2-bluetooth-2.15.2
> (Thank you very much for the patch!)

Ok, i was not sure if this was "good enough", since abusing the list of services seemed "strange", but i could not do better with my limited YCP knowledge ;-)

> BTW, I suppose that the change during package update is handled by bluez
> themselves...

Yes, there is this snippet in the specfile, which works for me:

%post -n bluez-utils
if [ -e /etc/sysconfig/bluetooth ]; then
        . /etc/sysconfig/bluetooth
        if [ x"$SDP_START" = "xyes" ]; then
                ARGS="-s"
                for i in $HCI_DAEMON_ARGS; do
                        case $i in
                        -s)     continue ;;
                        *)      ARGS="$ARGS $i" ;;
                        esac
                done
                sed -i -e "s@^HCI_DAEMON_ARGS.*\$@HCI_DAEMON_ARGS=\"$ARGS\"@;" /etc/sysconfig/bluetooth
        fi
fi
%{fillup_only -n bluetooth}

If you find that it does not work (or if you get a bugreport for this), don't hesitate to complain (and assign the bug to me :)