Bug 280145

Summary:	Updating from 'Unknown product' to 'Unknown product' in FACTORY Update module
Product:	[openSUSE] openSUSE 10.3	Reporter:	Gerald Pfeifer <gp>
Component:	YaST2	Assignee:	Lukas Ocilka <locilka>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	holler
Version:	Alpha 4plus
Target Milestone:	---
Hardware:	x86-64
OS:	openSUSE 10.3
Whiteboard:
Found By:	Product Management	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	Screenshot hilighting the issue y2log

Description Gerald Pfeifer 2007-06-01 18:37:57 UTC

Running the new FACTORY Update module for the first time on my STABLE
installation, I noticed a warning of

  'Unknown product' to 'Unknown product' 

in the initial screen of that module when, at the same time, the next
line read "Update to openSUSE FACTORY 10.3".

This is not consistent, and the warning message also is quite confusing.

Comment 1 Gerald Pfeifer 2007-06-01 18:38:18 UTC

Created attachment 143666 [details]
Screenshot hilighting the issue

Comment 2 Gerald Pfeifer 2007-06-01 18:38:39 UTC

Created attachment 143667 [details]
y2log

Comment 3 Hans-Peter Holler 2007-06-02 17:10:49 UTC

Please look at #274064.
Assigned to Lukas Ocilka.

Comment 4 Lukas Ocilka 2007-06-04 07:40:57 UTC

Update.ycp:489 SuSERelease::ReleaseInformation: openSUSE 10.3
Found matching product: $["label":"openSUSE FACTORY 10.3", "productname":"openSUSE-factory", "productversion":"10.3", "relnotesurl":"http://www.suse.com/relnotes/i386/openSUSE/FACTORY/release-notes.rpm", "vendor":"SUSE LINUX Products GmbH, Nuernberg, Germany"]
Update.ycp:618 update from $["major":10, "minor":3, "name":"openSUSE", "nameandversion":"openSUSE 10.3", "show":"openSUSE 10.3", "version":"10.3"] to $["major":10, "minor":3, "name":"openSUSE FACTORY 10.3", "nameandversion":"openSUSE FACTORY 10.3 10.3", "show":"openSUSE FACTORY 10.3", 
"version":"10.3"]

I have to admit that the message is confusing :) My mistake...
This is the proposed patch:

Index: update_proposal.ycp
===================================================================
--- update_proposal.ycp (revision 38257)
+++ update_proposal.ycp (working copy)
@@ -451,9 +451,9 @@
                // TRANSLATORS: proposal warning, both %1 and %2 are replaced with product names
                _("Warning: Updating from '%1' to '%2', products do not exactly match."),
                // TRANSLATORS: unknown product name
-               _("Unknown product"),
+               Update::installedVersion["show"]:_("Unknown product"),
                // TRANSLATORS: unknown product name
-               _("Unknown product")
+               Update::updateVersion["show"]:_("Unknown product")
            );
        }

Anyway, this will still produce a warning:
--- cut ---
Warning: Updating from 'openSUSE 10.3' to 'openSUSE FACTORY 10.3', products do not exactly match.
--- cut ---

Despite having only one additional word, the products are different, FACTORY provides another product name that is than written into the /etc/SuSE-release.

Anyway, it might be a bit broken by design because product "openSUSE FACTORY 10.3" IS also installed in that system but only as an Add-On product, additionally, there is _NO_ base product in ZYPP.
Product.ycp:86 All found products: [$["category":"add-on", "description":"openSUSE FACTORY 10.3", "display_name":"openSUSE FACTORY 10.3", "flags":["update"], "name":"openSUSE-factory", "relnotes_url":"http://www.suse.com/relnotes/i386/openSUSE/FACTORY/release-notes.rpm", "short_name":"FACTORY", "summary":"openSUSE FACTORY 10.3", "update_urls":[], "vendor":"", "version":"10.3"]]
Product.ycp:98 Found base products: []
Product.ycp:99 No base product found

Comment 5 Lukas Ocilka 2007-06-04 07:41:38 UTC

- Displaying correct product names (from/to) in the FACTORY update
  proposal in warning message when products don't match (#280145).
- yast2-update-2.15.13