Bug 298942

Summary:	opensuse-updater-kde: misleading/unnecessary dialog
Product:	[openSUSE] openSUSE 10.3	Reporter:	Stephan Binner <stbinner>
Component:	YaST2	Assignee:	Thomas Göttlicher <tgoettlicher>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None
Version:	Alpha 7
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Stephan Binner 2007-08-09 17:29:05 UTC

After installing an update which "requires the restart of the package manager" an information dialog appears stating "One of installed patches affects the package manager itself, thus it requires restart before executing next operations."

Talking about package manager when the update notification applet is meant is slighty misleading. I would even suggest to remove the dialog as the user can almost not notify that the applet gets restarted (or it actually doesn't?) and thus cannot be get confused like by a full-screen package manager window disappearing.

PS: Some more "the" and "a" in above sentence would make it imo better.

Comment 1 Thomas Göttlicher 2007-08-13 12:39:45 UTC

Hi Jano.

This message is shown because opensuseupdater calls zypper and displays all output of zypper and zypper prints this message.

I have different ideas how to remove this message. But none has no disadvantages.

- Remove this message from zypper's xml output. 
  Contra: Zypper should be usable not only for opensuseupdater.

- Add an option --no-restart-message to zypper
  Contra: Another option would make zypper's syntax more complex

- opensuseupdater tries not to show this message.
  Contra: With translations of zypper output this might be difficult.

- Add an additional attribute to XML output. Example:
  <message type="warning" text="..." kind="restart-message">
  This would solve the problem with translations
  Contra: XML would be a little more complex

Do you know any solutions?

I would prefer the the extended XML with kind="restart-message". 
May I add this to zypper?

Comment 2 Jan Kupec 2007-08-13 13:09:28 UTC

IMO, the message should be removed from the xml output. opensuse-updater should check zypper's exit value for ZYPPER_EXIT_INF_RESTART_NEEDED and provide it's own message (or whatever handling) for such case. No need for a "restart-message" attribute.

Comment 3 Thomas Göttlicher 2007-08-13 13:46:15 UTC

Thank you. I will do that.

Comment 4 Thomas Göttlicher 2007-08-13 13:58:37 UTC

This is fixed in zypper's svn r6627.

Comment 5 Stephan Binner 2007-08-15 15:14:37 UTC

Should be also than in latest Factory submission which includes up to r6675 :-)...