Bug 341840

Summary: One click installer fails when named HTML entities are included in the description
Product: [openSUSE] openSUSE 10.3 Reporter: Forgotten User DVG0Sx8gYR <forgotten_DVG0Sx8gYR>
Component: YaST2Assignee: Pascal Bleser <pascal.bleser>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: benji, tgoettlicher
Version: Final   
Target Milestone: ---   
Hardware: PowerPC   
OS: openSUSE 10.3   
Whiteboard:
Found By: Customer Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Screenshot showing error window

Description Forgotten User DVG0Sx8gYR 2007-11-15 01:34:04 UTC
Using one-click install to add additional packages fails if the descriptive text in the .ymp file includes "named" HTML entities are included. As an example, the .ymp file from the Packman repository for transcode includes the HTML entity &Ouml; in four different locations. This causes the installer to fail, complaining of an "undefined entity at line xx, column yy, byte zzzz" where xx, yy, zzzz point to the blank space before the entity.

As a test, replacing the first &Ouml; with &copy; also resulted in the same undefined entity error, whereas replacing the &Ouml; with &#65; didn't.
Comment 1 Forgotten User DVG0Sx8gYR 2007-11-15 01:34:49 UTC
Created attachment 183447 [details]
Screenshot showing error window
Comment 2 Thomas Göttlicher 2007-11-27 10:14:14 UTC
Reassigning to maintainer.
Comment 3 Martin Vidner 2007-11-27 11:22:31 UTC
Well, YMPs are XML, not HTML. So using &Ouml; without defining it first in the same file is a well-fomedness error. Better complain to whoever produced the ymp file.

$ cat ouml.xml
<?xml version="1.0" encoding="UTF-8"?>
<foo>Hell&ouml; w&ouml;rld!</foo>
$ xmllint ouml.xml
ouml.xml:2: parser error : Entity 'ouml' not defined
<foo>Hell&ouml; w&ouml;rld!</foo>
Comment 4 Benjamin Weber 2007-11-27 13:05:09 UTC
I fixed it so it catches the invalid XML errors. SVN version will now get

http://bw.uwcs.co.uk/OCI/screenshots/invalid_ymp.png
Comment 5 Benjamin Weber 2007-11-27 13:05:59 UTC
Assigning to pascal to fix escaping in packman YMPs.
Comment 6 Pascal Bleser 2007-12-12 20:58:39 UTC
Should be fixed now. I disabled the HTML entity escaping for YMP requests (except for &gt; and &lt;). It sends back UTF-8 directly.