Bug 350662

Summary: g-m-m: Patch to improved startup time
Product: [openSUSE] openSUSE 11.0 Reporter: Magnus Boman <mboman>
Component: GNOMEAssignee: Scott Reeves <sreeves>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: casualprogrammer, federico, forgotten_CRPsQFwJ3b
Version: Alpha 3   
Target Milestone: ---   
Hardware: Other   
OS: openSUSE 10.3   
Whiteboard: gnome-performance
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 349357    
Attachments: Patch

Description Magnus Boman 2007-12-25 22:58:17 UTC
Created attachment 188705 [details]
Patch

Attached is a patch which improves the startup time of g-m-m.

tile_table_reload was called once for each section created, and then again for all sections in apply_lockdown_settings. This patch makes sure that tile_table_reload is only called once per section.
A (nice) side-effect of this is that it also doesn't create unnecessary tiles which it later have to delete as they don't fit in the window.

This patch also fixes a bug where the apply_lockdown_settings did not update Recently Used Documents.

kcachegrind shows lr cost...
...Before this patch: 2 844 609 350
...After this patch:    996 026 118
Comment 1 Federico Mena Quintero 2008-04-05 05:04:32 UTC
This patch kicks total ass.

I submitted it for openSUSE 11.0 along with the fix for bug #230478 (see that bug for the actual patch).
Comment 2 Federico Mena Quintero 2008-04-19 03:23:38 UTC
*** Bug 370926 has been marked as a duplicate of this bug. ***