Bug 368570

Summary: switch "OK" and "Abort" buttons in yast2 ca_mgm "export as common server certificate"
Product: [openSUSE] openSUSE 11.4 Reporter: Casual J. Programmer <casualprogrammer>
Component: YaST2Assignee: E-mail List <bnc-team-screening>
Status: RESOLVED DUPLICATE QA Contact: Jiri Srain <jsrain>
Severity: Enhancement    
Priority: P4 - Low CC: forgotten_h13THG8RK1, jdsn, mc
Version: Factory   
Target Milestone: ---   
Hardware: x86   
OS: openSUSE 11.0   
Whiteboard:
Found By: Beta-Customer Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Screenshot of situation

Description Casual J. Programmer 2008-03-10 08:48:19 UTC
When exporting a common server certificate with yast2 ca_mgm the button for OK is located in the left bottom corner, while the button for abort is in the bottom right corner. As far as I experience it, yast2 usually has it the other way round. i.e. abort left, OK, next, apply etc. on the right.

Notebook: Fujitsu Siemens Amilo Si 1520
Graphics: Fujitsu Siemens Mobile 945GM/GMS/GME, 943/940GML Express
Monitor:  QUANTADISPLAY LCD Monitor 1280x800@60Hz
Wireless: Intel PRO/Wireless 3945ABG Network Connection
Sound:    82801G (ICH7 Family) High Definition Audio Controller
Desktop:  gnome2-SuSE-10.3-166
YaST GUI: yast2-qt-2.16.32-2
OS:       openSUSE 11.0 (i586) Alpha2 VERSION = 11.0
Kernel:   2.6.24.1-6-pae

yast2-ca-management-2.16.5-13
Comment 1 Casual J. Programmer 2008-03-10 08:48:59 UTC
Created attachment 199785 [details]
Screenshot of situation
Comment 2 Casual J. Programmer 2008-05-03 10:49:27 UTC
yast2-ca-management-2.16.6-11 still has it :-(
Comment 3 Michael Calmer 2008-09-03 14:23:29 UTC
Not sure if you are right.

http://en.opensuse.org/YaST/Style_Guide#Single_Configuration.2FOverview.2FEdit_Dialog

This looks like the button order is ok. Let's ask our Usibility Team.
Comment 4 J. Daniel Schmidt 2008-09-03 15:16:05 UTC
This is indeed the default YaST button layout.
But as there were requests to support as well the reverse button order used in Gnome, YaST now introduced a new Widget for that: the buttonbox.
It will take care of sortig the buttons in the correct order according to the windowmanager used.

For details see:
http://en.opensuse.org/YaST/Development/Misc/Button_Order

As a single use of this new buttonbox will make YaST inconsistent with itself we have to wait for a general and complete switch (_and_ full test) to the new widget. I doubt that this is possible for Code11, but most likely after that.


Btw. Concerning your screenshot: The "Ok" button in the wizard in the right bottom corner is actually a "Finish" button, the module creator just changed its label text.
IMO this is the only bug I can find in this report.


Martin, any further comments?
Comment 5 Forgotten User h13THG8RK1 2008-09-03 16:26:35 UTC
(In reply to comment #4 from Jens Daniel Schmidt)
> As a single use of this new buttonbox will make YaST inconsistent with itself
> we have to wait for a general and complete switch (_and_ full test) to the new
> widget. I doubt that this is possible for Code11, but most likely after that.
> 
> 
 modules/Popup.ycp is already using the ButtonBox which is the base class for pretty much every popup dialog. Either use Popup.ycp or use the ButtonBox.
 Either way, put OK and Abort next to each other.
Comment 6 Martin Schmidkunz 2008-09-04 11:00:31 UTC
As Jens already mentioned, YaST will take care of sorting the buttons in the correct order according to the windowmanager used.

However I see the button order in the pop up and in the overview is wrong (according to the YaST style guide):

* The buttons in the overview dialog should be OK/Cancel because it is an overview of the certificate details and not a wizard 
(http://en.opensuse.org/YaST/Style_Guide#Single_Configuration.2FOverview.2FEdit_Dialog)

* The buttons in the pop up should be labeled OK/Cancel and should be aligned in the center (for KDE) or down on the right (for GNOME). I think, susing popup.ycp should handle the button alignment correctly. 
Comment 7 J. Daniel Schmidt 2008-12-04 17:49:07 UTC
There are a lot of buttons in this module. We will change to the new ButtonBox-magic after CODE11 (after 11.1 is released).
Comment 8 Casual J. Programmer 2009-01-14 18:29:16 UTC
To me it looks like it's still the wrong way round(11.1 final)
Comment 9 Larry Finger 2011-04-04 05:31:08 UTC
Closed wit WONTFIX
Comment 10 Casual J. Programmer 2011-04-04 06:05:25 UTC
Is this the new openSUSE way to "fix" bugs ? 

Leaving them untouched for several years, then close as WONTFIX or NORESPONSE ?

Why should anybody bother to submit bug reports, if nothing becomes of them anyway ?

I'm sure you can do better.
Comment 11 J. Daniel Schmidt 2011-04-04 13:56:39 UTC
(In reply to comment #10)
> Is this the new openSUSE way to "fix" bugs ? 
> Leaving them untouched for several years, then close as WONTFIX or NORESPONSE ?

No it is not. Seems to be aside-effect of the OpenBugsDay:
  http://en.opensuse.org/openSUSE:Open-Bugs-Day
All old bugs were closed ignoring the content in them.

This bug was kept open as reminder to switch all YaST modules to use the ButtonBox widget. The ButtonBox automagically sorts the buttons in an order that is consistent with the current desktop environment. This is an enhancement and valid for all YaST modules.
Comment 12 J. Daniel Schmidt 2011-04-04 14:07:33 UTC
Closing as duplicate of a bug that tracks the switch to a consistent use of the ButtonBox in all YaST modules.

*** This bug has been marked as a duplicate of bug 684863 ***