Bug 381956

Summary:	Repository Manager doesn't work during installation
Product:	[openSUSE] openSUSE 11.0	Reporter:	Forgotten User DVG0Sx8gYR <forgotten_DVG0Sx8gYR>
Component:	Installation	Assignee:	Stefan Hundhammer <shundhammer>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	coolo, forgotten_h13THG8RK1, jsrain, locilka, lslezak, mmeeks
Version:	Beta 1
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Beta-Customer	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Forgotten User DVG0Sx8gYR 2008-04-21 14:24:32 UTC

During the installation, it's possible to add extra repositories by checking the "Include Add-On Products" checkbox. However, it isn't possible to use the Repository Manager to make any changes to these repositories before the installation begins. To make changes, you need to go backwards through the screens until you reach the installation mode screen.

To try use the Repository Manager from the Installation Summary screen, you need to change the software selection, click on the "Details" button at the bottom of the "Software Selection and System Tasks" screen, then select the Repository Manager menu option under the Repositories menu. Doing this sends you back to the  "Software Selection and System Tasks" screen.

Comment 1 Lukas Ocilka 2008-04-23 14:23:02 UTC

During the installation, adding new sources or removing them should be done via Add-On Products as mentioned above.

Repository manager should not offer the functionality as it doesn't handle the other issues (Add-Ons have some special internal handling).

The second part of the report sounds strange. It maybe sends `back instead of `accept or `next.

Comment 2 Lukas Ocilka 2008-04-23 14:23:20 UTC

Please, attach YaST logs.

Comment 3 Ladislav Slezák 2008-04-23 14:45:06 UTC

The problem is that `repo_mgr is returned, which is not handled.

(The logs are not needed in this case.)

Comment 4 Ladislav Slezák 2008-04-23 14:45:31 UTC

*** Bug 382003 has been marked as a duplicate of this bug. ***

Comment 5 Ladislav Slezák 2008-04-23 15:35:22 UTC

I think there are two solutions:

- add support for `repo_mgr into installation - start the add-on module
  (the add-on summary dialog should be displayed), repositories.ycp shouldn't be
  used in this case (see comment #1)

- add `opt(`repo_mgr) option to the `PackageSelector widget to explicitly enable
  the repository management feature (but some users might be confused why the
  option is missing during installation)

I think the first solution is better.

And I'm thinking about the other Yast modules which use the PackageSelector widget, like the product creator, online update... They also needs to be fixed in a similar way.

Comments?

Comment 6 Lukas Ocilka 2008-04-23 15:43:24 UTC

Just a reminder: Add-Ons in installation can also change the installation workflow (and another internal things). That's why we should use yast-add-on instead of yast-repositories there.

Comment 7 Stephan Kulow 2008-04-23 16:51:23 UTC

I don't think there is need for a repo mgr in installation, so I would go for #2, but I see it's more complicated

Comment 8 Ladislav Slezák 2008-04-30 13:46:14 UTC

I just have added `opt(`repoMgr) to `PackageSelector widget so the "Repository" menu is optional now (default is off).

Implemented in yast2-libyui-2.16.47, yast2-ycp-ui-bindings-2.16.46. A patch for yast2-qt-pkg has been submitted into SVN. (Not submitted to abuild yet, Steffan please, do that.)

Ncurses and Gtk package selectors must be adapted by their maintainers (YPackageSelector::repoMgrEnabled() returns true if "Repository" item should be displayed).

The yast scripts do not show the menu during installation (yast2-packager-2.16.43).

Comment 9 Stefan Hundhammer 2008-04-30 15:55:08 UTC

Submitted as yast2-qt-pkg-2.16.40.

Comment 10 Forgotten User h13THG8RK1 2008-05-05 18:34:53 UTC

Added support for this new flag to yast-gtk.