Bug 385315

Created attachment 211571 [details]
unreadable pop-up

That's in fact a feature. In the popup the user can select Apply
or Finish: Apply commits the changes and returns to the partitioner
and Finish commits the changes and exits.

Maybe something for the partitioner redesign in 11.1.

Note: The package selector solves the issue in a different way:
After Apply the user is asked whether to return to the package
selector or exit. This should be made consistent across YaST.

Concerning the partitioner redesign for 11.1:
* it will certainly have no full-colored pop-ups. Instead of this there should be a warning icon
* secondly the pop-up does not make sense semantically either: "Apply, Cancel, Finish" are no appropriate answers to the question "Do you really want to...?". Yes/No makes much more sense.

Concerning the workflow:
I fully agree with Tanja.
It is highly confusing and we should avoid these kind of traps for the redesign and in the current module. Even it does not make sense from a technical perspective it is the users perspective and expectations we need to take into account. 
I suggest to fix this according to Tanja's ideas.
 

Just an idea:
What about just closing the partitioner module when the user clicks on "Apply" (or "Yes" which should be there :-))?

Startup of the partitioner can be very slow with lots of disks
(say 15 minutes). In that case it's very convenient and speedy
if the user can apply changes and then continue making further
changes.

Another suggestion would be:
Maybe also the label "OK" is not correct for the partitioner.
What about using "Cancel" and "Apply" and if there are no changes done the "Apply" button is disabled? 
 

Disabling buttons does not give the user a hint why it's disabled,
e.g. it could be disabled because no changes where made or because
the setup is invalid.

Sorry I did not participate in this discussion again since the day I filed the bug but I urgently needed to finish some 11.0 doc parts first that had to go out for translation... 

Perhaps what Arvin mentioned in Comment #2 about the the package selector would be a solution for the partitioner as well? 

I can understand the technical reasons behind the current solution (and also the advantages Arvin mentions in Comment #5) but I still think the current status is highly confusing from a user's point of view and that it should be changed for 11.1 and SLE 11, if possible. It does not necessarily have to be totally different, it just need to be clearer for the user what happens.  

It would be fine for me to do it similar to the software management module.

Bug still there in 11.0 GM. Impossible to exit partitioner without clicking the "little X" in the upper right hand  corner of the window.
This really should be fixed.  The fact that it has not been fixed yet, presents a bad impression of the developers attention to detail; and their willingness to do a GM release with know usability errors. 

This pop-up is evil. Not only has it totally wrong and confusing button set, but it also present crucial information in very limited space. 

IMAO information of such relevance ('all the movies on your disk will be wiped out') does not belong to the tiny popup, but deserves full-screen summary, much like e.g. yast2-firewall has.

Just an idea: 
After clicking on 'Accept' *) in the main dialog (I'm referring to these slides: http://files.opensuse.org/opensuse/en/8/87/Partitioner_pres15.pdf) a full screen summary dialog like this would appear

+---------------------------------------------+
|Summary of changes:                          |  
|  * /dev/sdaX will be deleted                |
|  * /dev/sdaY will be formatted as reiserfs  |
|  * something else happens etc.              |
|                                             |
|                                             |
|                                             |
|                                             |
| [Help]                 [Back][Abort][Finish]|
+---------------------------------------------+

Now after seeing comprehensive summary of all changes, user could either change his mind and go 'Back' to revisit changes, 'Abort' the whole modules (throwing away the changes), or 'Finish' and apply the changes. 
This is an approach consistent with the rest of YaST (ad comment #2 - this popup has been removed from package selector recently as it was found quite useless :) )

Martin: can we include some ideas for summary screen (be it popup - which I don't quite like - or a full screen) in our mockups mentioned above?

(*) Now we should probably rename it to 'Next'

Very good point, Katharina - I also like the summary idea, it would be very appropriate for that purpose and consistent with the rest...

Great idea, Bubli!

Ideas for a summary (slide 27):
http://en.opensuse.org/Image:Partitioner_pres16.pdf

Seems as though the partitioner redesign has not solved the initial (and for me main problem): after enabling the quota support and confirming the changes to /etc/fstab in the (now readable) pop-up, I clicked Accept to close the Expert Partitioner and a pop-up still tells me "No unsaved changes exist". So I still have to leave the partitioner with Abort, though my changes have been saved. 

So I guess I have to open the same bug for openSUSE 11.1 or what would be the correct Bugzilla procedure now? Martin, Arvin - to whom of you to assign this copied bug then? 

Hi, Tanja,

I know :) I have implementing this on my to-do list, unfortunately it's in a queue behind few blockers and criticals at the moment. 
You don't have to open a new bug. I'll take this one.

*** Bug 429940 has been marked as a duplicate of this bug. ***

Sorry, I was too hasty and had opened a new one while you were reacting on this one :).  I closed it again as duplicate of this one. Thanks Bubli!

This is finally done (will be in y2-storage 2.17-49)

Tanja: I don't know much about recommended procedures when it comes to updating documentation, should I pass this bug to docu team so they can adjust SLE11 manuals?

Bubli, thanks for fixing! I have already found a "workaround" for my text snippet, CC'ing Berthold so he can check the partitioner chapter if any changes are needed there.