Bug 386548

Summary: Monsoon won't accept new torrent added by external applications while running
Product: [openSUSE] openSUSE 11.0 Reporter: Christian Jäger <christian.jaeger>
Component: GNOMEAssignee: Michael Wolf <maw>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Critical    
Priority: P5 - None CC: hendry.jared
Version: Beta 2   
Target Milestone: ---   
Hardware: x86-64   
OS: Other   
Whiteboard: gnome-function-does-not-work
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 386552    
Attachments: Patch against 0.11.3 which can be applied to factory.
Updated patch against 0.11.3
Updated patch against 0.11.3 which can be applied to factory
fix for loading torrents while running

Description Christian Jäger 2008-05-05 01:57:01 UTC
Monsoon won't add new torrents to the queue while running; e.g. it is not possible to add a torrent file to Monsoon's queue via Firefox. Not even double-clicking a torrent in Nautilus will ad it to the queue. Only opening torrent within Monsoon itself will work.
Comment 1 Alan McGovern 2008-05-05 10:36:20 UTC
This is a known issue. It's not a quick fix unfortunately. There are plans in the works to fix this issue and it will be implemented for 0.12.
Comment 2 Alan McGovern 2008-05-05 19:04:08 UTC
I tell a lie. 'Proper' single instance detection should be done using dbus. I've implemented 'good enough' detection which does the job nicely. This is now available in SVN.
Comment 3 Christian Jäger 2008-05-05 21:03:55 UTC
Fine. :-) When can we expect to see the code in Factory?
Comment 4 Alan McGovern 2008-05-05 21:33:18 UTC
When the next release from trunk is made. So, probably 2-4 weeks.
Comment 5 Christian Jäger 2008-05-05 22:34:54 UTC
...so it will definitely be in time to make it into 11.0 final?
Comment 6 Alan McGovern 2008-05-05 23:13:58 UTC
This will be pushed into 0.11.4, which will be done in plenty of time to hit suse 11.0 final.
Comment 7 Alan McGovern 2008-05-08 00:19:01 UTC
Created attachment 213343 [details]
Patch against 0.11.3 which can be applied to factory.

Attaching a patch against 0.11.3. This can be integrated into the factory build.
Comment 8 Michael Wolf 2008-05-08 00:24:23 UTC
Reopening, to assign to me to get the patch info Factory
Comment 9 Michael Wolf 2008-05-08 00:25:11 UTC
Dear me,

Please add the patch mentioned in comment #7.

Sincerely,
me.
Comment 10 Michael Wolf 2008-05-08 14:13:19 UTC
Done.
Comment 11 Jared Hendry 2008-05-09 10:32:09 UTC
Created attachment 213870 [details]
Updated patch against 0.11.3

Updated patch to fix 'Directory does not exist' exception encountered when running Monsoon for the first time.
Comment 12 Jared Hendry 2008-05-09 10:34:03 UTC
Reopening to get updated patch into factory
Comment 13 Jared Hendry 2008-05-09 13:37:10 UTC
Created attachment 213940 [details]
Updated patch against 0.11.3 which can be applied to factory

Added a piece of code which was omitted from the original patch
Comment 14 Alan McGovern 2008-05-09 17:51:03 UTC
Created attachment 214035 [details]
fix for loading torrents while running

The previous patch didn't handle the case where the torrent was already loaded in monsoon correctly.

This patch was tested using all three methods to insert a torrent for both the case where the torrent was not already loaded and when it was already loaded. Sehr gut!
Comment 15 JP Rosevear 2008-05-12 15:25:13 UTC
Maw submitted the update.