Bug 392171

Summary:	buttons order doesn't adapt to that of GNOME
Product:	[openSUSE] openSUSE 11.0	Reporter:	Forgotten User CRPsQFwJ3b <forgotten_CRPsQFwJ3b>
Component:	YaST2	Assignee:	Lukas Ocilka <locilka>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None	CC:	forgotten_h13THG8RK1, locilka, michael.monreal
Version:	Factory
Target Milestone:	---
Hardware:	x86
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Forgotten User CRPsQFwJ3b 2008-05-19 17:03:34 UTC

The order of the buttons in yast-gtk import key dialog is:

[Import] [Don't Import]

but in order to be consistent with GNOME it should be:

[Don't Import] [Import]

That's because everything that involves ok/cancel yes/no has the order:

[No/Cancel] [Yes/OK]

And because I already have that model in my spatial memory I keep pressing the right hand side button, which in the case of YaST-gtk is the "No" one instead of "Yes".

Comment 1 Forgotten User h13THG8RK1 2008-05-23 16:39:04 UTC

Hi Ivan. This isn't really possible to get done in time for 11.0. Furthermore, this requires more significant changes that would go beyond the GTK specific code -- possibly touching the code of all yast individual tools -- and I don't see much interest in solving this -- and we have tried to get this feature discussed a few times in the past already... But again, no way we'll be able to see this for 11.0, and yast guys already have a lot of issues to keep them busy already, so let's try to get it ready for the next one.

Comment 2 Stephan Kulow 2008-06-25 09:11:53 UTC

mass reopening of later+remind bugs of 11.0

Comment 3 Forgotten User h13THG8RK1 2008-06-25 15:12:28 UTC

Please assign or add as CC yast2-libyui's maintainer, so we can discuss this.

Comment 4 Stefan Hundhammer 2008-06-27 12:44:25 UTC

That's a long-standing feature request. There are huge discussions somewhere.

Comment 5 Forgotten User h13THG8RK1 2008-06-29 01:16:45 UTC

*** Bug 404822 has been marked as a duplicate of this bug. ***

Comment 6 Forgotten User h13THG8RK1 2008-08-29 21:07:15 UTC

Ivan, Stefan here has implemented that in SVN. Please stay tuned for the 11.1 Betas (or check the next Alpha already if possible) to see if the particular instance you are reporting has been fixed. Greatly appreciated!

Comment 7 Stefan Hundhammer 2008-09-02 13:10:26 UTC

See also

http://lizards.opensuse.org/author/sh-sh-sh/
http://en.opensuse.org/YaST/Development/Misc/Button_Order

Comment 8 Forgotten User h13THG8RK1 2008-09-03 16:57:11 UTC

Lukas, it seems that modules/SignatureCheckDialogs.ycp doesn't use yet the ButtonBox. Could you change that? (you'll also have to change the `import and `dont_import id to something like `yes_import and `no_import ...)

Comment 9 Lukas Ocilka 2008-09-04 08:38:29 UTC

Only one function (ItemSignedWithPublicSignature) didn't use the ButtonBox widget.

I don't need to change `import to `yes_import because the module uses these params:

    * `import --> `opt (`okButton, `key_F10)
    * `dont_import --> `opt (`cancelButton, `key_F9)

these `opt arguments overrule `id(s)

Comment 10 Lukas Ocilka 2008-09-04 08:38:52 UTC

Fixed in yast2-2.17.17