Bug 392983

Summary:	yast2 printer - error message in ncurses
Product:	[openSUSE] openSUSE 11.0	Reporter:	Michal Zugec <mzugec>
Component:	YaST2	Assignee:	Jiri Srain <jsrain>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Critical
Priority:	P5 - None	CC:	accounts, nugenesis
Version:	Factory	Flags:	coolo: SHIP_STOPPER+
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Comment 1 Stephan Kulow 2008-05-21 11:58:27 UTC

what is private in this bug?

Comment 2 Katarina Machalkova 2008-05-21 12:58:57 UTC

The main culprit is here (CWM.ycp - AdjustButtons function):

            if (back != "")
                Wizard::SetBackButton (`back, back);
            else if (help != "")
                Wizard::SetBackButton (`help, help);

First, back button should not be replaced with something with ID `help. This ID is reserved for the main help button which needs to be accesible at all times (since we now have a help in a separate popup window).

I've checked in a naive patch (svn r47752) removing Miso's problem (evil red popup on printer startup), but CWM-master needs to look at this, because now at least two more issues surfaced:

1. In printer's common/dialogs.ycp this:

 symbol ret = DialogTree::ShowAndRun ($[
            
            "back_button"       : nil,
            "abort_button"      : Label::AbortButton(),
            
            )
        ]);

should hide back button. However, with my patch it does not

2. Help texts are empty for the first two tree items (global settings, printers and queues)

Comment 3 Michal Zugec 2008-05-21 14:25:33 UTC

*** Bug 391814 has been marked as a duplicate of this bug. ***

Comment 4 Jiri Srain 2008-05-23 08:52:04 UTC

Missing help texts have been reported as bnc #393871, the texts are missing at all in the printer module sources.

The code which is responsible for showing/hiding buttons is from the time when there was no place to have both Help and Back buttons, in general, the fix which you did seems correct, I will have a look at the remaining issue.

Comment 5 Jiri Srain 2008-05-23 11:13:20 UTC

I cleaned the code up a bit, so that it reflects the new layout (help always on button, the 'Help' and 'Back' buttons can now be shown together.

yast2.rpm submitted to autobuild.

Comment 6 Stefan Hundhammer 2008-05-26 15:38:24 UTC

*** Bug 393887 has been marked as a duplicate of this bug. ***