Bug 404818

Summary: Yast GTK package manager icons
Product: [openSUSE] openSUSE 11.0 Reporter: Michael Monreal <michael.monreal>
Component: YaST2Assignee: Forgotten User h13THG8RK1 <forgotten_h13THG8RK1>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: forgotten_h13THG8RK1
Version: Final   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Screenshot for reference
screenshot

Description Michael Monreal 2008-06-28 13:51:19 UTC
Two issues:

a) not all of the icons on the left pane use tango artwork, while correct icons are available (Education, Office => as used by the Upstream gnome menu)

b) The icons for Available/Upgrades/Installed as well as the various icons used in the package list below (same three + uninstall etc) don't seem to contain alpha transparency, making them look bad.
Also, the icons for Available/Upgrades/Installed don't seem to be the best choices for this task.
- "Upgrades" should use the software-update-available icon from the icon theme spec.
- Problem with the current available icon is that it looks like network software. I would use the package-x-generic icon for Installed and a custom icon (a silhouette of a package perhaps?) for Available. IMHO this would make the GUI functions more obvious for the user.
Comment 1 Michael Monreal 2008-06-28 13:55:13 UTC
Created attachment 224995 [details]
Screenshot for reference

...containing new icon suggestions
Comment 2 Forgotten User h13THG8RK1 2008-06-29 01:26:08 UTC
For the groups thing, I think we are just using the same as yast2-qt is. If there are better ones available, we'll make use of them. Will check out your suggestions for the status icons as well.

(for curiosity, the reason why alpha transparency isn't respected as in the original ones is because we have used the XPM format in order to easily embed them in the code. If we use some already shipped with Gnome, then we aren't going to embed them in the executable.)
Comment 3 Michael Monreal 2008-06-29 08:43:53 UTC
Ok... I just found out that the education icon is no longer part of the icon theme spec and was removed from tango :( but if you want to ship it with yast that would be possible. For office you can use the "applications-office" category icon which should be available in all themes. There's also "applications-system" which may be a better fit for the "System" category.

"Other desktops" and "XFCE" currently use the same icon which is not very nice as well... perhaps use the "user-desktop" spec icon for "Other desktops" and a special icon (like GNOME and KDE) for XFCE? And for "Unknown" "applications-other" would probably fit.
Comment 4 Michael Monreal 2008-06-29 08:45:49 UTC
Btw it's also possible to store .png pixmaps in the executable (see GdkPixdata) but storing them separately (or using themed icons) is "better" of cause.
Comment 5 Forgotten User h13THG8RK1 2008-06-29 10:33:23 UTC
(In reply to comment #4 from Michael Monreal)
> Btw it's also possible to store .png pixmaps in the executable (see GdkPixdata)
> but storing them separately (or using themed icons) is "better" of cause.
> 
Sure, I did use the word "easily". One should be able to easily write some code that grabs any binary file and write those bytes into an inlined array. In the end, we would paste something like:
   const unsigned char png_data[] = { 0xff, 0x6a, .... };
A XPM, on the other hand, is already done and sliced for you. The XPM file already looks like something like:
   const char *image_data = "jkhelu3534i234wekljw ... ";

Anyway, compiling this data into the executable isn't that good of an idea. These data isn't even used for anything other than the package selector thing. But it's just four or five icons, and our executable is much smaller than the qt one already, so I didn't bother going through all the trouble to make it work for automake. (I'm only comfortable with plain old Makefile files...) However, we want to ship our icons in separated files from the executable... Maybe now will be a good time to kill a few birds at once. ;)
Comment 6 Forgotten User h13THG8RK1 2008-07-31 01:40:44 UTC
I fixed the XFCE group icon and a couple others as suggested. With regard to the quality of the icons on the top, I'd need someone knowledge with autoconf to check that out. Let's try to do that at a later day.
Comment 7 Bugzilla Account Maintenance 2008-09-02 18:07:51 UTC
Because the LATER and REMIND resolutions have been removed, the resolution of this bug has changed from LATER to WONTFIX. If this bug needs to be reconsidered, reopen it and set a future "Target Milestone for Fix."
Comment 8 Forgotten User h13THG8RK1 2008-10-28 18:42:27 UTC
Michael, installing some quality PNG icons then. (At /usr/share/YaST2/gtk if you'd like to tweak something. ;))

Based the installed & available icons on the PackageKit ones. Not sure if the install and remove icons look a bit off, especially because they don't look quite the same size, but, on the other hand, I feel PackageKit ones don't contrast enough... Will append shot...

Asked for a yast2-gtk to be built to Factory.
Comment 9 Forgotten User h13THG8RK1 2008-10-28 18:44:17 UTC
Created attachment 248402 [details]
screenshot