Bug 419159

Summary:	sax2: YaST2 keyboard without display testing
Product:	[openSUSE] openSUSE 11.1	Reporter:	Karl Eichwalder <ke>
Component:	SaX2	Assignee:	Stefan Dirsch <sndirsch>
Status:	RESOLVED DUPLICATE	QA Contact:	E-mail List <sax2-maintainer-bugs>
Severity:	Enhancement
Priority:	P5 - None	CC:	ms
Version:	Factory
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Documentation	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Karl Eichwalder 2008-08-21 11:38:26 UTC

I think there is not need to test the display configuration, if the user changes the keyboard layout only.  To reproduce:

Click "Keyboard Layout" in the YaST CC (gtk).  SaX2 starts with the Keyboard Properties dialog.

Change "Layout" from English to German.

Click "OK".  Now a message pop-up wants you to test the configuration which is superfluous, I'd say.

Comment 1 Stefan Dirsch 2008-08-21 11:53:30 UTC

Makes sense to me. Marcus, how to implement this?

Comment 2 Marcus Schaefer 2008-08-21 13:29:56 UTC

you need to make the last message more "intelligent". Normally sax2 is
called as complete application but it also can be called with only a
specific dialog. In case of a specific dialog it might be better to have
a specific last message too.

1) Take a look at api/frame.cpp

void SCCFrame::slotFinish ( void ) {   
    ...
}

this is the code which displays the message when ok is clicked

2) the variable 

   mRequestedDialog

contains the dialog if one was requested. You can adapt the slotFinish
function to handle the mRequestedDialog information and display different
messages here

Be aware that you need to introduce new texts and this also requires a
new pot file in the localization repository

Comment 3 Stefan Dirsch 2008-08-21 14:52:50 UTC

Thanks!

Comment 4 Stefan Dirsch 2008-08-27 02:39:26 UTC

This issue becomes obsolete with the proposal in Bug #389072, comment #9.

*** This bug has been marked as a duplicate of bug 389072 ***