Bug 423174

Summary: Using check box to start IrDA module instead of radio button
Product: [openSUSE] openSUSE 11.1 Reporter: Martin Schmidkunz <mschmidkunz>
Component: YaST2Assignee: Jiří Suchomel <jsuchome>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Enhancement    
Priority: P5 - None    
Version: Alpha 2   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: IrDA with check box

Description Martin Schmidkunz 2008-09-04 14:53:23 UTC
According to the YaST style guide a check box should be used to toggle between two states (http://en.opensuse.org/YaST/Style_Guide#Dialog_Elements_AKA_Controls).
Currently IrDA module uses a radio button.

What do you think about the following small redesign?
Comment 1 Martin Schmidkunz 2008-09-04 14:53:58 UTC
Created attachment 237559 [details]
IrDA with check box
Comment 2 Jiří Suchomel 2008-09-26 14:18:19 UTC
I tend to think that this style guide should not be strictly followed.
Comment 3 Jiří Suchomel 2008-10-01 08:51:50 UTC
not sure...
Comment 4 Martin Schmidkunz 2008-10-02 08:57:14 UTC
Mhm. The reason why a style guide was created, was to unify some basic elements so the user doesn't have to reorganize himself when switching modules.
Of course the style guide is not intended not to dictate you every single pixel in your module.
It is intended to standardize certain things, so that they are consistent, which eases working with your module and makes the user more appreciate what you have created for him.
If I am not wrong there are only few things described in the style guide after all and they deal mainly with navigation buttons, add/edit/delete buttons and the enable/disable issue.

So, if you have any objections about things in the style guide, please come up with them (like you did with the check box issue).
It is really important to me, that you (and all the other developers) are comfortable with because what use would a style guide be if none follows it? 
Comment 5 Martin Schmidkunz 2008-10-02 12:24:37 UTC
see bug #423190 for discussion