Bug 423190

Summary:	Using check box to use Kerberos Client module instead of radio button
Product:	[openSUSE] openSUSE 11.1	Reporter:	Martin Schmidkunz <mschmidkunz>
Component:	YaST2	Assignee:	Jiří Suchomel <jsuchome>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Minor
Priority:	P5 - None
Version:	Alpha 2
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	kerberos client module using check box kerberos client module using check box

Description Martin Schmidkunz 2008-09-04 15:15:33 UTC

According to the YaST style guide a check box should be used to toggle between
two states
(http://en.opensuse.org/YaST/Style_Guide#Dialog_Elements_AKA_Controls).
Currently kerberos client module uses a radio button.

What do you think about the following small redesign?

Comment 1 Martin Schmidkunz 2008-09-04 15:16:09 UTC

Created attachment 237575 [details]
kerberos client module using check box

Comment 2 Martin Schmidkunz 2008-09-04 15:25:12 UTC

Created attachment 237584 [details]
kerberos client module using check box

Comment 3 Jiří Suchomel 2008-09-26 12:55:59 UTC

I think RadioButton is nicer. And it is in the same style as e.g. ldap-client (which has more than 2 options)

Comment 4 Jiří Suchomel 2008-09-29 07:30:21 UTC

What do you think?

Comment 5 Martin Schmidkunz 2008-10-02 09:07:32 UTC

The main idea why we put this check box thing into the style guide was because GNOME uses check boxes to enable/disable something.
There are pros and cons arguments for using radio buttons or check boxes so maybe we could also use radio buttons to enable/disable something.
Lukas, Bubli, what do you think about that?

Comment 6 Jiří Suchomel 2008-10-02 10:17:30 UTC

(this is also answer to bug 423174, no need to discuss at more places)

I agree there is no fundamental reason against the style guide, my main one could be called conservativeness, or in other words, do not change things that have settled look just so they fit into some category.

Than there is a point of comment 3: ldap-client has a reason for radio buttons and it has sense to have all those "authentication" clients share the same style.

And last one is that now I have some urgent work in other areas than rebuilding the UI... :-(

Comment 7 Martin Schmidkunz 2008-10-02 12:23:07 UTC

Agreed.
I will change the style guide and we will use radio buttons to enable/disable things.
Basically I don't care, whether we use radio buttons or check boxes. I am more interested in having one, consistent solution.

> And last one is that now I have some urgent work in other areas than rebuilding
> the UI... :-(

Yes, I know. That's one other reason, why I am pulling my previous suggestion back.

Thanks for bringing this issue up and discussing it!

Cu