|
Bugzilla – Full Text Bug Listing |
| Summary: | compiz: activating neg, blur, static switcher plugins segfaults compiz | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.1 | Reporter: | Jigish Gohil <cyberorg> |
| Component: | Compiz | Assignee: | David Reveman <dreveman> |
| Status: | RESOLVED FIXED | QA Contact: | Bryan Perry <bperry> |
| Severity: | Critical | ||
| Priority: | P2 - High | CC: | aaatoja, dannybaumann, lmedinas, mmeeks |
| Version: | Factory | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: |
crash report
crash report blur Blur plugin fix Neg plugin fix. ColorFilter plugin fix Cube plugin fix. |
||
|
Description
Jigish Gohil
2008-10-04 14:13:20 UTC
Marked "major" as this is one of the popular accessibility features of compiz. Adding more plugins crashing compiz. This does not happen on vanilla compiz (without NOMAD patches) Raising the issue to critical as many users are going to use other profile than default via simple-ccsm resulting in compiz crash. Also compiz is enabled by default now so stability should be improved. *** Bug 432451 has been marked as a duplicate of this bug. *** Created attachment 243716 [details]
crash report
crash report when activating neg plugin
Created attachment 243718 [details]
crash report blur
blur and neg assume in their objectAdd functions for window objects that the parent object is a CompScreen* - which doesn't seem to be the case anymore. From what I understand when reading the code, it seems that the root window is treated as normal window now, what would explain it. David, mind telling us how this is supposed to work? The root window now being represented as a CompWindow object and top-level windows being children of this object is all part of the support for having compiz not only support top-level window compositing but also compositing of sub-windows. All windows except the root window has a CompWindow object as parent. Sorry, I didn't have time to test all plugins and make sure they got adjusted properly before the feature freeze deadline. These issues are all very easy to fix though. I'll attach patches for the above mentioned plugins. If you find other plugins that don't work properly due to these changes please let me know and I'll get them fixed asap. Created attachment 244021 [details]
Blur plugin fix
Created attachment 244024 [details]
Neg plugin fix.
Created attachment 244025 [details]
ColorFilter plugin fix
I can't find anything wrong with the jpeg plugin. Is that one actually causing a crash too? Created attachment 244066 [details]
Cube plugin fix.
David, all these patches are in the last compiz submission you did, right? If so, let's close the bug Adding one more crashing plugin to the list: static switcher. From bug #434252 "It seems the static switcher is missing some symbols: (gdb) r Starting program: /usr/bin/compiz --ignore-desktop-hints --indirect-rendering --replace ccp [Thread debugging using libthread_db enabled] /usr/bin/compiz: symbol lookup error: /usr/lib/compiz/libstaticswitcher.so: undefined symbol: unhookWindowFromScreen Program exited with code 0177. We used to have this type of problem in OO.o; then we added a 'checkdll' thing that makes sure all symbols are defined when you load a plugin. It'd be great to replicate something like this in compiz I guess - so these are caught at compile time, not run-time." *** Bug 434252 has been marked as a duplicate of this bug. *** Static switcher still crashes with "undefined symbol: unhookWindowFromScreen" Using 11.1 B4 and the latest packages from X11:Compiz repo. The package seems to be untouched since October, 13th. The static switcher doesn't segfault with the latest FACTORY packages. All these plugins now work fine. |