|
Bugzilla – Full Text Bug Listing |
| Summary: | Wrong Release Notes format (in openSUSE) | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.1 | Reporter: | Karl Eichwalder <ke> |
| Component: | YaST2 | Assignee: | Karl Eichwalder <ke> |
| Status: | RESOLVED FIXED | QA Contact: | Jiri Srain <jsrain> |
| Severity: | Major | ||
| Priority: | P2 - High | CC: | birger.kollstrand, gs, kukuk, locilka |
| Version: | Beta 2 | ||
| Target Milestone: | Beta 4 | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | Documentation | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: | y2log | ||
|
Description
Karl Eichwalder
2008-10-07 10:33:21 UTC
I'm afraid I don't quite understand. If the language is English, the english version of release notes is shown and there are obviously no Czech/Russian letters in it, or ... ? Or maybe I have different dialog in mind, can you please specify how to reproduce the bug (i.e. how to have yast display R.N. in all languages)? Created attachment 243948 [details]
y2log
After rebooting, at the end of the installation once the Internet test is done. Because "cs" comes first in openSUSE, yast displays it.
inst_release_notes.ycp fails to find the preferred language because the regexpmatch doesn't work any longer. The file name obviously has changed (was RELEASE-NOTES.<lang>.rtf and now is RELEASE-NOTES-<product>.<lang>.rtf). There are also some other places where the regular expression doesn't fit. Proposed patch: Index: src/clients/inst_release_notes.ycp =================================================================== 128c128 < return regexpmatch (one_relnotes, "^RELEASE-NOTES\..*\.rtf$"); --- > return regexpmatch (one_relnotes, "^RELEASE-NOTES.*\\..*\\.rtf$"); 133c133 < string relnotes_lang = regexpsub (one_relnotes, "^RELEASE-NOTES\.(.*)\.rtf$", "\\1"); --- > string relnotes_lang = regexpsub (one_relnotes, "^RELEASE-NOTES.*\\.(.*)\\.rtf$", "\\1"); 156c156 < if (regexpmatch (item_id, sformat ("RELEASE-NOTES\.%1\.rtf$", preffered_lang))) { --- > if (regexpmatch (item_id, sformat ("RELEASE-NOTES.*\\.%1\\.rtf$", preffered_lang))) { The '.' has to be escaped with '\\'. I can't think of a solution for the other problem that after changing the language e.g. to czech some characters aren't displayed correctly. To display the characters of the choosen language, the appropriate font has to be loaded. But the button labels and text will remain in installation language. Submitted to /work. *** Bug 438112 has been marked as a duplicate of this bug. *** *** Bug 439011 has been marked as a duplicate of this bug. *** |