Bug 433373

Summary: su-wrapper-1.2.0-447: 2 * ordered comparison of pointer with integer zero
Product: [openSUSE] openSUSE 11.1 Reporter: David Binderman <dcb314>
Component: OtherAssignee: Dr. Werner Fink <werner>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.0   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2008-10-08 09:23:04 UTC
I just tried to compile Suse Linux package su-wrapper-1.2.0-447
and the compiler said

su-wrapper.c:258: warning: ordered comparison of pointer with integer zero

The source code is

        if ((new_pwd = lookup_pwd(entry->run_user)) < 0)

Suggest replace with

        if ((new_pwd = lookup_pwd(entry->run_user)) == 0)

Similar fun & games nearby with

su-wrapper.c:261: warning: ordered comparison of pointer with integer zero
Comment 1 Dr. Werner Fink 2008-10-08 10:27:29 UTC
fixed