Bug 433780

Thanks for catching this, I'll take care of it for beta3.

Hmm, so how should the the variables look like in the netconfigX files? Just without quotes like this?

SERVICE=NetworkManager
INTERFACE=cable
CREATETIME=1223419459

How about values with spaces, like

DNSSERVERS=192.168.0.1 192.168.0.2

or with quotes?

When you provide input via stdin to netconfig modify, use explicit single
quotes (the quote character ' is not allowed inside of the value an can't
be quoted) even when there are no spaces in the value.

The netconfig modify arguments without additional quotes around the value,
for example:

  SERVICE='NetworkManager'
  INTERFACE='eth0'
  DNSSERVERS='192.168.0.1 192.168.0.2'
  {
    echo "INTERFACE='$INTERFACE'
    echo "DNSSERVERS='$DNSSERVERS'"
  } | /sbin/netconfig modify -s "$SERVICE" -i "$INTERFACE"

or

  /sbin/netconfig modify -s "$SERVICE" -i "$INTERFACE" <<-EOF
  INTERFACE='$INTERFACE'
  DNSSERVERS='$DNSSERVERS'
  EOF

This means, the argruments have to contain the bare string values:

 ... argv[] = { "/sbin/netconfig", "-s", "NetworkManager",
                                   "-i", "eth0", NULL};

The expected input format is dhcpcd complatible key='value string';
see also the "dhcpcd -T eth0" output, e.g.:
  INTERFACE='eth0'
  DNSSERVERS='192.168.0.1 192.168.0.2'


I'm adding some code to netconfig rejecting invalid args & input.

The keys have to be compatible with shell identifiers + a single
quoted value:

/^[[:space:]]*[a-z_][a-z0-9_]*='[^']*'[[:space:]]*$/ && !/^[[:space:]]*_+=/

We don't allow unquoted values to go away a misinterpretation as
a bash reserved word, ... and keep it simple.

Hmm, in that case, I don't see any bugs in NM at all, NM does always use a single quote (') around each value. This is a sample from NM log:

Spawning '/sbin/netconfig modify --service NetworkManager'
Writing to netconfig: INTERFACE='eth0'
Writing to netconfig: DNSSEARCH='lan'
Writing to netconfig: DNSSERVERS='192.168.0.3'

There's no shell involved, so these are the exact values netconfig gets. NM never uses "-i" command line argument, the interface is always passed over stdin.

Created attachment 245167 [details]
Proposed patch for netconfig

(In reply to comment #4 from Tambet Ingo)
> Hmm, in that case, I don't see any bugs in NM at all, NM does always use a
> single quote (') around each value. This is a sample from NM log:
> 
> Spawning '/sbin/netconfig modify --service NetworkManager'
> Writing to netconfig: INTERFACE='eth0'
> Writing to netconfig: DNSSEARCH='lan'
> Writing to netconfig: DNSSERVERS='192.168.0.3'
> 
> There's no shell involved, so these are the exact values netconfig gets. NM
> never uses "-i" command line argument, the interface is always passed over
> stdin.

Ah... I've found the bug. You're right - it didn't came via -i but via
stdin:
  if [ "x$val1" = "xINTERFACE" ]; then
   _INTERFACE="$val2"
  fi
The $val2 contained "'ethX'" at this time.... means it's my bug :-)

Anyway, the above patch should fix both possibilities in netconfig.
Going to submit all fixes to STABLE in few minutes...

Created attachment 245171 [details]
complete /etc/sysconfig/network/scripts/functions.netconfig

Created attachment 245173 [details]
complete /sbin/netconfig

Can you test if the files from attachment #245171 [details] +  this one work for you?

Fix submitted to STABLE/Factory.

*** Bug 431322 has been marked as a duplicate of this bug. ***

This is an autogenerated message for OBS integration:
This bug (433780) was mentioned in
https://build.opensuse.org/request/show/2839 Factory / sysconfig