Bug 440518

Martin, this is for all these new bugs:
- I agree that the back button does not have a sense when it behaves same way as the Cancel/Abort button
- but I don't see the linked Single Configuration/Overview/Edit Dialog as a good example: those are dialogs inside the main dialog, that have only Cancel/OK buttons. But the main imho should be different: here when you click Cancel or OK,the module exits, not just current window. I think this part of style guide is not precise enough and needs some more investigation.

Hi Jiri!

Thanks for your comments!
Originally I was hoping to avoid those mass bug reporting by asking around on the yast-devel mailing list, but as this didn't turned out any results, I decided to go this way.
So please excuse the mass filing.

Mhm. The original idea behind OK/Cancel was:
* Cancel: Go back to previous screen and do not save changes
* OK: Go back to previous screen and save changes

When opening "Edit" this would mean:
* Cancel: Go back to the main overview screen and do not save changes
* OK: Go back to the main overview screen and save changes

When opening the main overview dialog or a single configuration dialog by starting a module the button labels would  mean:
* Cancel: Go back to the control center by closing the dialog and do not save changes
* OK: Go back to the control center by closing the dialog and do not save changes

That's why I think, that it makes sense to use OK/Cancel in main overview dialogs, single configuration and in edit dialogs.

Does that make sense to you?
Should I add this to the style guide?

(In reply to comment #2 from Martin Schmidkunz)
> Hi Jiri!
> 
> Thanks for your comments!
> Originally I was hoping to avoid those mass bug reporting by asking around on
> the yast-devel mailing list, but as this didn't turned out any results, I
> decided to go this way.
> So please excuse the mass filing.

Mass filling would not be a problem, the problem I see is that this part of style guide is not ready (although we thought it is).


> When opening the main overview dialog or a single configuration dialog by
> starting a module the button labels would  mean:
> * Cancel: Go back to the control center by closing the dialog and do not save
> changes
> * OK: Go back to the control center by closing the dialog and do not save
> changes

OK from main dialog always closes the whole yast module AND saves changes. This is difference from the other OK's in the module. Control center itself does not have any information about what is going on in modules and you can start YaST modules without control center anyway.

And btw, you can't tell those ldap/kerberos/users start dialogs are overview ones. Thy present some basic setting, while other dialogs in these modules are usually for more expert settings, but the first dialog does not reflect them, so it can't be called overview.

Mhm. Obviously there is a kind of misunderstanding as I thought as well that this part would be ready :-(

So let's see:
Maybe it is technically not 100% correct to label edit/overview/single configuration buttons with the same label.
My points in favor of labeling them nonetheless with the same labels are:
* consistency of user expectations (MS Windows uses only OK/Cancel, KDE uses OK/Cancel/Apply, GNOME uses OK/Cancel/Apply)
* similar actions (the dialog I opened is closed with no changes upon Cancel and closed with items either marked for changes or the changes are actually saved)

Do you have any other ideas for this issue?



No, ldap, kerberos, users are (even in my view :-)) single configuration dialogs.

(In reply to comment #4 from Martin Schmidkunz)
> Mhm. Obviously there is a kind of misunderstanding as I thought as well that
> this part would be ready :-(
> 
> So let's see:
> Maybe it is technically not 100% correct to label edit/overview/single
> configuration buttons with the same label.
> My points in favor of labeling them nonetheless with the same labels are:
> * consistency of user expectations (MS Windows uses only OK/Cancel, KDE uses
> OK/Cancel/Apply, GNOME uses OK/Cancel/Apply)
> * similar actions (the dialog I opened is closed with no changes upon Cancel
> and closed with items either marked for changes or the changes are actually
> saved)

The difference I mean is not between overview or single configuration
dialogs or how the different kind of dialogs is named based on the look.\

The difference is between all the dialogs that are opened from certain yast module (when these are closed, the control is returned to that module) and between the main dialog of module, which, when closed either drops all the data (Cancel) or saves them (OK/Finish). The behavior is different, saving the data is done only at this one place so I think it should be distinguished by the button label(s), I propose leaving Finish there (Cancel is fine, and Back should be dropped).

OK, I give up, although I do not think it is correct. But now there are more modules with the new style.