Bug 440560

Summary: button labeling in scanner module
Product: [openSUSE] openSUSE 11.1 Reporter: Martin Schmidkunz <mschmidkunz>
Component: YaST2Assignee: Johannes Meixner <jsmeix>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Enhancement    
Priority: P5 - None CC: jsrain
Version: Beta 3   
Target Milestone: RC 1   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: wizard buttons that should be relabeled in scanner module

Description Martin Schmidkunz 2008-10-31 12:02:37 UTC
When opening the module the user is presented with an overview.
On the other hand wizard buttons are used for main navigation.

Please change the buttons according to the YaST style guide
(http://en.opensuse.org/YaST/Style_Guide#Single_Configuration.2FOverview.2FEdit_Dialog)
from "Abort", "Back", "Finish" into "Cancel" / "OK" and do not show/drop the
"Back " button.

Please consider using the button box widget to maximize consistency with
whichever desktop the user has chosen.
Comment 1 Stefan Hundhammer 2008-10-31 14:04:23 UTC
Not sure if the module maintainer can do anything about that, or if there was a change in some framework used by all modules...

Johannes? Jiri?

Martin: A screenshot pointing out the problem would be nice.
Comment 2 Martin Schmidkunz 2008-10-31 15:21:05 UTC
@Stefan:
Thanks for your comment!

I attached a screenshot.

I would like to ask:
* rename "Abort" into "Cancel"
* rename "Finish" into "OK"
* remove/do not show "Back"

Thanks!
Comment 3 Martin Schmidkunz 2008-10-31 15:21:53 UTC
Created attachment 249144 [details]
wizard buttons that should be relabeled in scanner module
Comment 4 Johannes Meixner 2008-10-31 15:25:39 UTC
Why must we re-label the buttons in each individual module
when the general style changed?

Why not re-label the defaults in the Wizard?
Comment 5 Johannes Meixner 2008-11-04 11:25:59 UTC
I removed the "Back" button from the Overview dialog because
in the Overview dialog there is nothing where to go back.

Either I rename all buttons in all my dialogs manually
according to comment #2 or I keep the names as is.
Otherwise the names in the Overview dialog would not
match to the names in the other dialogs.

Now I have

in the Overview dialog:
[Cancel] [OK] according to
http://en.opensuse.org/YaST/Style_Guide#Single_Configuration.2FOverview.2FEdit_Dialog

in the model and driver selection dialog
(first dialog of a wizard stlye dialog sequence)
[Cancel] [Back](disabled) [Next] according to
http://en.opensuse.org/YaST/Style_Guide#Configuration_Wizard

in the scanning via network dialog
(a single configuration dialog)
[Cancel] [OK] according to
http://en.opensuse.org/YaST/Style_Guide#Single_Configuration.2FOverview.2FEdit_Dialog


Now I do it all manually by overwriting the defaults of the
Wizard module which is the really best way to end up in
endless confusion - but this seems exactly what is wanted.

In particular when I submit it also for older openSUSE versions
via the openSUSE build service: What a nice look and feel
when users of older openSUSE versions will get new button
names (hardcoded by my manual overwrite) which do not match
to their other (older) YaST modules.
Comment 6 Johannes Meixner 2008-11-04 11:45:05 UTC
Submitted yast2-scanner 2.17.2 to FACTORY/STABLE.
Comment 7 Johannes Meixner 2008-11-11 11:22:50 UTC
FYI regarding the expected mess and confusion (see comment #5),
of course it does happen (Murphy’s Law): See bug #443684.
Comment 8 Johannes Meixner 2009-10-28 08:43:54 UTC
One more regarding the expected mess and confusion (see comment #5),
see the "Yast2 Hardware on RC1" thread on opensuse-factory
dated end of October 2009, in particular
http://lists.opensuse.org/opensuse-factory/2009-10/msg00504.html