|
Bugzilla – Full Text Bug Listing |
| Summary: | scmon-0.3-82.19: missing expression in return | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.1 | Reporter: | David Binderman <dcb314> |
| Component: | Other | Assignee: | Christian Zoz <zoz> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | ||
| Version: | Factory | ||
| Target Milestone: | Beta 4 | ||
| Hardware: | All | ||
| OS: | openSUSE 11.0 | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
David, thanks for the report. This obviously looks wrong.
Although I'm not the maintainer of the package as he seems to be gone, I'll submit the following patch:
--- monitor/sclog.c 2007-05-23 17:48:44.000000000 +0200
+++ monitor/sclog.c 2008-11-09 10:45:46.000000000 +0100
@@ -78,7 +78,7 @@ write_a_string (int fd, const gchar *s)
len = strlen (s);
if (len == 0) {
- return;
+ return FALSE;
}
written = 0;
Submitted to STABLE, closing as fixed. |
I just tried to build the OpenSuse factory package scmon-0.3-82.19 and the compiler said monitor/sclog.c:81: warning: 'return' with no value, in function returning non-void The source code is if (len == 0) { return; } I agree with the compiler, the code is broken. Suggest add expression to return statement.