|
Bugzilla – Full Text Bug Listing |
| Summary: | gstreamer-0_10-plugins-bad-0.10.8-4.8: call to wrong C++ delete | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.1 | Reporter: | David Binderman <dcb314> |
| Component: | Other | Assignee: | Stanislav Brabec <sbrabec> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | ||
| Version: | Factory | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | openSUSE 11.0 | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: | hal-smart-card.patch | ||
Created attachment 264603 [details]
hal-smart-card.patch
OOPS, bad bug #. This code is a part of libmodplug. This code was part of gst-plugins-bad-0.10, but now it depends on an external library, which is not part of openSUSE yet, It could be probably added to keep gst-plugins-bad features. Reported upstream: https://sourceforge.net/tracker/?func=detail&aid=2777464&group_id=1275&atid=301275 New libmodplug package with the fix was submitted to openSUSE:Factory. |
I just checked some of the source code in the Suse Linux factory package gstreamer-0_10-plugins-bad-0.10.8-4.8 and I noticed the following $ egrep "new|delete" ../BUILD/gst-plugins-bad-0.10.8/gst/modplug/libmodplug/load_mdl.cpp | fgrep m_lpszSongComments if (m_lpszSongComments) delete m_lpszSongComments; m_lpszSongComments = new char[blocklen]; The if test is a waste of time and the delete is wrong. Suggest replace line of code with delete [] m_lpszSongComments; m_lpszSongComments = NULL;