Bug 443722

Summary: kadslwatch-01.00.06-245.19: 4 * call to wrong C++ delete
Product: [openSUSE] openSUSE 11.1 Reporter: David Binderman <dcb314>
Component: KDE4 ApplicationsAssignee: E-mail List <kde-maintainers>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.0   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2008-11-11 12:29:26 UTC
I just checked some of the source code in the Suse Linux factory package
kadslwatch-01.00.06-245.19 and I noticed the following

$ egrep "new|delete" ../BUILD/kadslwatch-01.00.06/src/ccapiinfo.cpp
                _cbyte* pBuffer = new _cbyte[64];
                delete pBuffer;
                _cbyte* pBuffer = new _cbyte[8];
                delete pBuffer;
                m_pManuData = new unsigned char[GetManuDataSize ()];
                if ( m_pManuData != NULL ) delete m_pManuData;
                                _cbyte* pBuffer = new _cbyte[64];
                delete pBuffer;

Lines two, four, six and eight look wrong. Suggest code rework.
Suggest new code

  delete [] pBuffer; pBuffer = NULL;
Comment 1 Lubos Lunak 2008-11-11 12:53:49 UTC

*** This bug has been marked as a duplicate of bug 442933 ***