Bug 450229

Created attachment 256728 [details]
yast2 logs

Daniel, please, check.
It's about setting the Internet::do_you variable.

I guess online update during installation is bound to registration, which we don't do anymore. This should still work - and as we need to test the update during installation this is a blocker per excellance (sorry, my frensh :)

(In reply to comment #3 from Stephan Kulow)
> I guess online update during installation is bound to registration,

No it is bound to the the Internet::do_you variable.
It defaults to "false". The network test no longer sets it to true on success and the registration is not run during openSUSE installation which also set it to true on success.

> which we
> don't do anymore. This should still work - and as we need to test the update
> during installation this is a blocker per excellance (sorry, my frensh :)

As the question whether or not to install updates was enhanced and only appears if there are really updates available, I'd recommend to just remove the check of the current "do_you"-state at the beginning of this module.

Any objections, Lukas?

Hmm, this means Internet::do_you is currently (newly) useless.

In this case, I can replace this

    if (!Internet::do_you) return `auto;

in inst_ask_online_update.ycp with

    if (NetworkService.ycp::isNetworkRunning() != true) return `auto;

opinions?

BTW: it changes the SLEx behavior a bit, but still doesn't run online update if not wanted by user. On the other hand, it would offer an online update even if user didn't run registration (on SLEx). In that case I'd tend to have it "fixed" on two places.

The default Internet::do_you would be set to 'true' and registration would disable it of not registered (or no update channel added).

Created attachment 256991 [details]
Proposed Patch

No it is not useless, it is the flag that online_update uses to check if it should start.
The client inst_ask_onlineupdate just set it to true if an update is wanted.
So did registration and in former times the network test.

I just tested the attached patch in an installation and it worked. Only the package manager did not start up in the update view but in the pattern view :(
This might be another issue.

Do you agree?

Sounds like a reasonable approach (if you figure out if you need the do_you flag or not)

Created attachment 256995 [details]
A bit more reliable patch proposal

Created attachment 256998 [details]
Patch proposal version 2

(In reply to comment #12 from Lukas Ocilka)
> A bit more reliable patch proposal

Yes, I agree, depending on the network being up is the better approach.
But with you patch #2 the following check for `skip is obsolete as well.

Lukas, do you want to add this patch?

Created attachment 257001 [details]
Patch proposal version 3

Yes, we've checked that with jsrain and found the same (I thought I've removed it already) but it seem to be an issue between keyboard and monitor.

- Fixed proposing the online update depending on the fact whether
  network is running (bnc #450229).
- yast2-installation-2.17.43

just tested openSUSE-11.1-RC2-DVD9-i586-x86_64-Build0001-Media.iso and it has the 2.17.43 and still skips. I'll attach logs as soon as the desktop started

Created attachment 257759 [details]
yast logs

Release notes are up btw and the test was successful

clients/inst_ask_online_update.ycp:116 Calling YaST client inst_ask_online_update (arguments: [$["enable_back":true, "enable_next":true]])
NetworkService.ycp:138 Network is running ...
clients/inst_ask_online_update.ycp:73 Pkg Builtin called: TargetInitialize
clients/inst_ask_online_update.ycp:74 Pkg Builtin called: TargetLoad
clients/inst_ask_online_update.ycp:75 Pkg Builtin called: SourceStartManager
clients/inst_ask_online_update.ycp:78 Pkg Builtin called: PkgSolve
clients/inst_ask_online_update.ycp:80 Pkg Builtin called: ResolvableCountPatches
clients/inst_ask_online_update.ycp:81 Available patches for pkg management: 0
clients/inst_ask_online_update.ycp:84 Pkg Builtin called: ResolvableCountPatches
clients/inst_ask_online_update.ycp:85 All available patches: 0
clients/inst_ask_online_update.ycp:88 No patch available, skiping offer to run YOU
Calling `inst_ask_online_update ($["enable_back":true, "enable_next":true]) returned `next

clients/inst_extrasources.ycp:191 Calling YaST client inst_extrasources (arguments: [$["enable_back":true, "enable_next":true]])
clients/inst_extrasources.ycp:52 Repositories to register: [$["alias":"repo-update", "autorefresh":true, "baseurl":"http://download.opensuse.org/update/11.1/", "enabled":true, "name":"openSUSE-11.1-Update", "priority":20, "prod_dir":"/"], $["alias":"repo-oss", "autorefresh":true, "baseurl":"http://download.opensuse.org/distribution/11.1/repo/oss/", "enabled":true, "name":"openSUSE-11.1-Oss", "priority":100, "prod_dir":"/"], $["alias":"repo-non-oss", "autorefresh":true, "baseurl":"http://download.opensuse.org/distribution/11.1/repo/non-oss/", "enabled":true, "name":"openSUSE-11.1-Non-Oss", "priority":100, "prod_dir":"/"], $["alias":"repo-debug", "autorefresh":true, "baseurl":"http://download.opensuse.org/debug/distribution/11.1/repo/oss/", "enabled":false, "name":"openSUSE-11.1-Debug", "priority":100, "prod_dir":"/"], $["alias":"repo-source", "autorefresh":true, "baseurl":"http://download.opensuse.org/source/distribution/11.1/repo/oss/", "enabled":false, "name":"openSUSE-11.1-Source", "priority":100, "prod_dir":"/"]]

No wonder ... repositories (also the update one) were added after running the inst_ask_online_update client (after checking for patches...)

- inst_extrasources moved before inst_ask_online_update to register
  the online update repository before checking for patches
  (bnc #450229).

New skelcd-control-openSUSE is in autobuild...

I have to admit that I don't have any possibility to test it here. Anyway, it should be possible to install the install the first stage, and before the system is rebooted to the second stage, copy the control.xml to /etc/YaST2/ on the system.