Bug 457104

Summary: Verify Installed Software reports problem in cups, Repair has no effect
Product: [openSUSE] openSUSE 11.1 Reporter: Jan van Male <jan.van.male>
Component: InstallationAssignee: Michael Schröder <mls>
Status: RESOLVED UPSTREAM QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P4 - Low CC: jsuchome, ma, mls, ncutler
Version: RC 1   
Target Milestone: ---   
Hardware: x86-64   
OS: openSUSE 11.1   
Whiteboard:
Found By: Community User Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Problem report from "Verify Installed Packages"
Screenshot from "Show Log"

Description Jan van Male 2008-12-07 14:44:16 UTC
(Split off from bug 456981 as requested by Andreas Jaeger)

On the installed system I see no problem:
# rpm --verify cups
#

Rebooting from the RC1 DVD into "Repair Installed System" -> "Expert Tools" -> "Verify Installed Software" reports a problem in cups, illustrated by the attached screenshots.

Checking "cups" and selecting "Repair" has no effect.
Comment 1 Jan van Male 2008-12-07 14:48:33 UTC
Created attachment 258484 [details]
Problem report from "Verify Installed Packages"
Comment 2 Jan van Male 2008-12-07 14:49:50 UTC
Created attachment 258485 [details]
Screenshot from "Show Log"
Comment 3 Klaus Singvogel 2008-12-08 09:30:21 UTC
Your "show long" screenshot shows that you (or one of your packages) change group ownership of directory "/usr/share/cups/drivers".

Don't know what to do here. It's not an issue with cups!

The "Repair Installed System" should be able to allow such changes in the system, or repair this. At least I'm unable to change the situation. Reassign back to AJ.
Comment 4 Michael Andres 2008-12-08 11:08:12 UTC
It's IMO not up to the verification tool to decide whether some change is acceptable or not. If a file is likely to change, the packager should 
indicate this by using an appropriate %noverify entry in the spec file.

/cups/drivers is group writable directory (0775), so it might be important to see which group now has write permissions.

We IMO should not change the tool to not report those changes. 

AJ?

---
- It may be an enhancement to display details e.g. like

  /usr/share/cups/drivers ......G. : drwxrwxr-x  root  ntadmin
                            actual : drwxrwxr-x  root  soemthingelse

- To allow the user to ignore certain 'errors'.

- And to detect whether such a change was caused by e.g. /etc/permissions.



Comment 5 Andreas Jaeger 2008-12-08 11:48:02 UTC
I don't know what YaST checks and what it should do.

I'm also confused since rpm does not report problems but YaST does.  If there's a packaging bug, it should be fixed in the package.

Comment 6 Klaus Singvogel 2008-12-08 12:36:08 UTC
I agree with Michael, the above change of group ownership should be set back to ownership as it is in the original rpm package. The "ntadmin" group ownership is done with intention as samba can easily deploy its drivers there. Changing it to any different group can make the use of samba very hard.

I think that's the primary job of the system repair function: fixing such changes in the system.

It's only worth a discussion, whether this change should be done after asking back the user or not.
Comment 7 Michael Andres 2008-12-08 17:13:21 UTC
*** Bug 457105 has been marked as a duplicate of this bug. ***
Comment 8 Michael Andres 2008-12-08 17:14:26 UTC
*** Bug 457106 has been marked as a duplicate of this bug. ***
Comment 9 Michael Andres 2008-12-08 17:31:38 UTC
(In reply to comment #5 from Andreas Jaeger)
> 
> I'm also confused since rpm does not report problems...

That's the important piece!

Now reading "rpm --verify shows no error msg" and looking again at the "Show Log" output, I suspect the (U)ser and (G)roup mismatches in the repair-system are due to incomplete /etc/passwd and /etc/group.

If the repair-systems /etc/group e.g. does not contain ntadmin, rpm will use 'root' for it. Thus verification fails:

# grep ntadmin /etc/group
# rpm -V cups
S.5....T  c /etc/cups/cupsd.conf
......G.    /usr/share/cups/drivers

In the running system, ntadmin is known, thus verification succeeds:

# grep ntadmin /etc/group
ntadmin:!:71:
# rpm -V cups
S.5....T  c /etc/cups/cupsd.conf


Comment 10 Josef Reidinger 2009-03-12 09:29:40 UTC
I try run rpm verify with root specified in mounted drive, but rpm still uses /etc/group instead /mnt/etc/group. Michael is it intended?
Comment 11 Michael Schröder 2009-03-12 11:03:44 UTC
No, I think this is a bug in rpm. It should be consistent with '-i', where it uses the passwd/group from the chroot directory.
Comment 12 Josef Reidinger 2009-03-12 11:10:09 UTC
OK, so I reassign it.
Steps to reproduce is easy -
rescue mode
mount /mnt
rpm -r /mnt -V cups

expected result is that it doesn't have any group problems.
Comment 13 Nathan Cutler 2017-08-11 13:47:49 UTC
Well, this bug has been open for ages and it is an issue in the software ("rpm") itself rather than in package/distribution, thus the report should go there.