Bug 457167

Summary: yast2 online update doesn't restart itself after installing pkg-management patches
Product: [openSUSE] openSUSE 11.1 Reporter: Jiří Suchomel <jsuchome>
Component: YaST2Assignee: Ladislav Slezák <lslezak>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Major    
Priority: P5 - None CC: coolo, dmueller, jsrain, jsuchome, lslezak, meissner
Version: RC 2Flags: coolo: SHIP_STOPPER-
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard: maint:running:21337 maint:released:11.1:22228
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: proposed patch for online_update.ycp
patch for /usr/share/YaST2/clients/menu.ycp

Description Jiří Suchomel 2008-12-08 09:08:25 UTC
yast2 online update doesn't restart itself after installing pkg-management patches: it only says it's going to restart but nothing happens. This is due to different behavior of yast return values...
Comment 1 Jiří Suchomel 2008-12-08 09:26:35 UTC
Created attachment 258544 [details]
proposed patch for online_update.ycp

In online_update.ycp, the negative return value cannot be used any more.
Comment 2 Jiří Suchomel 2008-12-08 09:27:45 UTC
Created attachment 258545 [details]
patch for /usr/share/YaST2/clients/menu.ycp

In menu.ycp, don't check for return value of online-update, but rather for file created...
Comment 3 Stephan Kulow 2008-12-08 09:48:33 UTC
Hmm, fixing this with a patch is hard. But then again yast online-update is not our default, so I have mixed feelings (taking that the fab waits ;(
Comment 4 Stephan Kulow 2008-12-08 09:49:41 UTC
10:47 < coolo> what does "nothing happens" mean? does the user has to restart himself or is the old update stack continueing?
10:47 < jsuchome> but it's up to you, of course... I guess first patch with yast stack will be out soon
10:47 < jsuchome> this is not during installation, only on installed system
10:48 < jsuchome> so there's nothing to continue, yast just finishes
10:48 < jsuchome> and user can start online update manually, yes

So this is just a glitch IMO and we should fix it with online update.
Comment 5 Marcus Meissner 2008-12-08 10:01:45 UTC
In my opinion: YOU works well enough, and since there are other methods, we do not need to fix it in the goldmaster.
Comment 6 Jiří Suchomel 2008-12-08 10:10:01 UTC
OK, lowering severity.
Comment 7 Jiří Suchomel 2008-12-08 14:50:18 UTC
As one part of the solution, yast2-online-update can't return integer value any more. This is in yast2-online-update-2.17.13.
Comment 8 Jiří Suchomel 2008-12-09 12:45:18 UTC
menu.ycp is fixed in yast2-2.17.59
Comment 9 Jiří Suchomel 2008-12-16 19:48:29 UTC
Coolo, I think this should be released for openSUSE as an update. Should I start with patchinfos or do we have some common one?

I mean packages yast2-2.17.59 and yast2-online-update-2.17.13. yast2-2.17.59 also contains the fix for bug 450528, which was not released with openSUSE, but I expect its realease as well.
Comment 12 Anja Stock 2008-12-18 10:12:17 UTC
swampid see whiteboard: 
maint:running:21337
Comment 13 Jiří Suchomel 2008-12-18 11:32:59 UTC
Summing up again - the patch needs these packages:

yast2-online-update >= 2.17.13
yast2 >= 2.17.59
yast2-pkg-bindings >= 2.17.31

Ladislav, there are already some new yast2 and yast2-pkg-bindings in Code11 svn, should they be included (= are they related to the new stuff added by fixing these bugs)?
Comment 14 Ladislav Slezák 2008-12-18 13:46:35 UTC
There are new unrelated functions which need the latest libzypp, for that reason I'd rather not submit the latest version (2.17.32).

I'll submit yast2=pkg-bindings-2.17.31 to 11.1.
Comment 15 Jiří Suchomel 2008-12-18 19:41:37 UTC
I've already submitted yast2-online-update-2.17.13 and yast2-2.17.59 to 11.1. Please close the bug as fixed when you submit yast2-pkg-bindings
Comment 16 Ladislav Slezák 2008-12-19 07:56:10 UTC
yast2-pkg-bindings-2.17.31. has just been submitted to 11.1, resolving as FIXED.
Comment 17 Swamp Workflow Management 2009-02-03 20:23:29 UTC
Update released for: gnome-packagekit, gnome-packagekit-lang, libqdialogsolver1, libqdialogsolver1-devel, libsatsolver, libsatsolver-devel, libzypp, libzypp-debuginfo, libzypp-debugsource, libzypp-devel, perl-satsolver, python-satsolver, ruby-satsolver, satsolver-tools, yast2, yast2-devel-doc, yast2-online-update, yast2-online-update-frontend, yast2-pkg-bindings, yast2-pkg-bindings-debuginfo, yast2-pkg-bindings-debugsource, zypper
Products:
openSUSE 11.1 (debug, i586, ppc, x86_64)