Bug 457691

Summary:	escape html tags for SlideShow::AppendMessageToInstLog?
Product:	[openSUSE] openSUSE 11.1	Reporter:	Arvin Schnell <aschnell>
Component:	YaST2	Assignee:	Stefan Hundhammer <shundhammer>
Status:	RESOLVED FIXED	QA Contact:	Jiri Srain <jsrain>
Severity:	Normal
Priority:	P5 - None
Version:	Factory
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	proposed patch example script proposed patch for yast2-qt

Description Arvin Schnell 2008-12-09 17:38:17 UTC

While looking at bug #450496 I realized that HTML tags included in a text
passed to SlideShow::AppendMessageToInstLog are interpreted in the resulting
log. I'm not sure were the tags should be escaped, by the caller or callee.

I would proposed to escape the tags in AppendMessageToInstLog.

Stano, I assigned this to you since you make changes for 11.1 in that
area.

Comment 1 Arvin Schnell 2008-12-09 17:38:41 UTC

Created attachment 258989 [details]
proposed patch

Comment 2 Arvin Schnell 2008-12-09 18:37:58 UTC

Hm, I'm confused now. The text gets passed to a LogView widget which
seems to not interpret HTML tags. Time to go home. Will check another
day.

Comment 3 Arvin Schnell 2008-12-09 19:29:46 UTC

Things are clearing up: The LogView for YaST-Qt UI apparently interprets
HTML tags when there are some in the first line. See attached example.

The documentation for LogView says "ASCII" output so this seems to be a
bug.

Interestingly in YQLogView.cc there is a _qt_text->setAcceptRichText(false)
call. Maybe a Qt issue (I still have Qt from 11.0).

Comment 4 Arvin Schnell 2008-12-09 19:30:52 UTC

Created attachment 259018 [details]
example script

Comment 5 Arvin Schnell 2008-12-09 20:14:33 UTC

Created attachment 259026 [details]
proposed patch for yast2-qt

Comment 6 Stefan Hundhammer 2008-12-10 11:09:58 UTC

Applied patch. Fix available with yast2-qt-2.17.24.