Bug 481416

Summary: disk name with "#" inside break menu.lst rewrite
Product: [openSUSE] openSUSE 11.1 Reporter: Marcus Meissner <meissner>
Component: BootloaderAssignee: Josef Reidinger <jreidinger>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P2 - High CC: forgotten__lyEjnLCxo
Version: Final   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard: maint:released:11.1:27643
Found By: Customer Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Marcus Meissner 2009-03-03 12:18:14 UTC
from an opensuse-security list mail:

> Example:
>    root=/dev/disk/by-id/scsi-SAreca_ARC-1210-VOL#000000000083264759-part3
>
>    became
>
>    root=/dev/disk/by-id/scsi-SAreca_ARC-1210-VOL


Funny name...
Comment 1 Josef Reidinger 2009-03-03 12:32:27 UTC
Thorsten - I look at parsing and need your help how exactly comments work in grub. # is parsed as special character in device.map and menu.lst. It is comment only if it is first character of line (both in device.map and in menu.lst, I am correct?
Comment 2 Forgotten User _lyEjnLCxo 2009-04-15 12:40:17 UTC
New kernel version 2.6.27.21-0.1-default was just installed - the same 
problem again :-(
So I think I will have to go back to the "old" and not recommended
names like /dev/sdxy :-(

Joe
Comment 3 Josef Reidinger 2009-04-16 13:11:38 UTC
I find info in manual...Problem is that perl-Bootloader shares routines to parse lines and lilo(elilo, ppc lilo) can have comment after text in line. But grub doesn't allow it and need special handling.
Comment 4 Josef Reidinger 2009-04-16 13:29:17 UTC
OK, fixed for grub in svn. Will be released as perl-Bootloader-0.5.0.
Comment 5 Josef Reidinger 2009-04-23 09:32:28 UTC
released as perl-Bootloader 0.5.0
Comment 6 Forgotten User _lyEjnLCxo 2009-06-16 06:36:15 UTC
NOT fixed.
Same Problem here today with Update to 2.6.27.23-0.1 (openSUSE 11.1)

Joe
Comment 7 Forgotten User _lyEjnLCxo 2009-06-16 06:40:07 UTC
From my menu.lst (after update):

kernel /vmlinuz-2.6.27.23-0.1-default root=/dev/disk/by-id/scsi-SAreca_ARC-1210-VOL resume=/dev/disk/by-id/scsi-SAreca_ARC-1210-VOL#0000004

It works for the resume entry, but not for the root device

Joe
Comment 8 Josef Reidinger 2009-06-16 10:13:20 UTC
Please specify what version of perl-Bootloader you use (`rpm -qf perl-Bootloader`)
Comment 9 Forgotten User _lyEjnLCxo 2009-06-16 10:52:40 UTC
perl-Bootloader-0.4.81.1-0.1.1

Yes, I had seen your note that it was "released as perl-Bootloader 0.5.0"
but I expected it would be backported.
Kernel updates are very important security updates - they should work without
fiddling around "by hand".

Joe
Comment 10 Josef Reidinger 2009-06-16 11:19:48 UTC
anja - What do you think about this update? I can add it to non-released update which waiting in queue. This update is only grub specific, as for *lilo is any # taken as comment. Tested in perl-Bootloader test-suite and also no negative response from factory where this fix is around two month.
Comment 13 Forgotten User _lyEjnLCxo 2009-08-28 08:52:54 UTC
Hm, new state after the last kernel update:
The "#" has been removed automagically while updating. This means: the menu.lst
entry does not match the device name again.
Is there a way to change the disk-by-id name of my root device to the new one in the menu.lst? (Googel didn't tell me)

Joe
Comment 14 Josef Reidinger 2009-09-03 08:45:58 UTC
Joe,
update is still not released for 11.1. You have two choice..change to e.g. disc-by-uuid and let yast2-bootloader to repropose configuration or use factory perl-bootloader.
Comment 17 Swamp Workflow Management 2009-09-16 15:22:46 UTC
The SWAMPID for this issue is 27336.
Please submit the patch and patchinfo file using this ID.
(https://swamp.suse.de/webswamp/wf/27336)
Comment 19 Josef Reidinger 2009-09-21 16:02:07 UTC
Released as pbl 0.4.81.2 for 11.1 (now in update test repo) and 0.4.89.1 for SLE11
Comment 20 Swamp Workflow Management 2009-11-30 10:40:58 UTC
Update released for: perl-Bootloader
Products:
openSUSE 11.1 (i586, ppc, x86_64)
Comment 21 Swamp Workflow Management 2009-12-02 13:06:20 UTC
Update released for: perl-Bootloader
Products:
SLE-DESKTOP 11 (i386, x86_64)
SLE-SERVER 11 (i386, ia64, ppc64, s390x, x86_64)