Bug 482339

Summary: openbabel-2.2.0-4.81: 2 * undefined code
Product: [openSUSE] openSUSE 11.2 Reporter: David Binderman <dcb314>
Component: OtherAssignee: E-mail List <kde-maintainers>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2009-03-05 11:53:14 UTC
I just tried to compile Factory package openbabel-2.2.0-4.81
and the compiler said

1.

ichirvr2.c:239: warning: operation on 'jn' may be undefined

The source code is

           at[jn = at[n_vertex].neighbor[1]].valence + at[jn].num_H == 3 &&

I agree with the compiler, the code is undefined.
Suggest code rework. Perhaps

           ((jn = at[n_vertex].neighbor[1]]),
                (at[ jn].valence + at[jn].num_H)) == 3 &&

would work.

2.

cl_list.c:496: warning: operation on 'item_count' may be undefined

similar.
Comment 1 Lubos Lunak 2009-03-17 16:31:08 UTC
.

*** This bug has been marked as a duplicate of bug 442933 ***