Bug 504889

Summary: kwatch-2.3.3-252.47: undefined code
Product: [openSUSE] openSUSE 11.2 Reporter: David Binderman <dcb314>
Component: KDE4 ApplicationsAssignee: E-mail List <kde-maintainers>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: forgotten_vXTZVacoSi
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2009-05-18 18:33:29 UTC
I just tried to build Factory package kwatch-2.3.3-252.47
and the build said

./kwatch/klogwidget.cpp:478: warning: operation on '((KLogWidget*)this)->KLogWidget::m_msgi' may be undefined

The source code is

    m_msgi = (++m_msgi % MAXKWATCHMSG);

I agree with the compiler. Better code would be

    m_msgi = (m_msgi + 1) % MAXKWATCHMSG);
Comment 1 Forgotten User vXTZVacoSi 2009-05-18 19:04:17 UTC
Please send patch to upstream project.

*** This bug has been marked as a duplicate of bug 442933 ***