Bug 514376

Summary: ktorrent-3.2.2-1.4: 2 * undefined code
Product: [openSUSE] openSUSE 11.2 Reporter: David Binderman <dcb314>
Component: OtherAssignee: E-mail List <kde-maintainers>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2009-06-18 13:33:01 UTC 
I just tried to build factory package ktorrent-3.2.2-1.4
The build said

1.

/usr/src/packages/BUILD/ktorrent-3.2.2/libbtcore/torrent/timeestimator.cpp:208:29: warning: operation on '((bt::SampleQueue*)this)->bt::SampleQueue::m_end' may be undefined

The source code is

                m_end = (++m_end) % m_size;

I agree with the compiler - the code is undefined.
Suggest new code

                m_end = (m_end + 1) % m_size;

2.

/usr/src/packages/BUILD/ktorrent-3.2.2/libbtcore/torrent/timeestimator.cpp:210:33: warning: operation on '((bt::SampleQueue*)this)->bt::SampleQueue::m_start' may be undefined

Duplicate.
Comment 1 Lubos Lunak 2009-06-22 13:55:43 UTC 
.

*** This bug has been marked as a duplicate of bug 442933 ***