|
Bugzilla – Full Text Bug Listing |
| Summary: | rdiff gives up | ||
|---|---|---|---|
| Product: | [Internal Novell Products] openSUSE Build Service | Reporter: | Michael Meeks <mmeeks> |
| Component: | webui | Assignee: | Sascha Peilicke <speilicke> |
| Status: | RESOLVED FIXED | QA Contact: | Adrian Schröter <adrian.schroeter> |
| Severity: | Normal | ||
| Priority: | P2 - High | CC: | suse-tux, vuntz |
| Version: | 2.2 | ||
| Target Milestone: | 2.2 | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Whiteboard: | |||
| Found By: | --- | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
(In reply to comment #0) > $ osc rdiff -u openSUSE:Factory sysconfig | wc -l > 261 > > why 261 ? ;-) is that 256 + 5 or ... The magic number is 200:) - the maximum number of lines for each file is 200 (without the header). This value is hardcoded in the bs_srcserver but I have no clue why. I assume there's a limit in order to avoid too big diffs because at the moment the complete diff is generated first and then sent to the user (in case of a very, very big diff this might lead to problems so we might need to send some chunks to the user instead of the whole diff). Hokay - if we can't block the diffing process on the network socket / flow-control to the client, then I guess that's what we have to do. It would be nice to have: a) a higher limit - 1000 lines ? b) a way of turning that off Thanks :-) *** Bug 519912 has been marked as a duplicate of this bug. *** What happens if we set that value to 1000? *** Bug 634304 has been marked as a duplicate of this bug. *** *** Bug 650476 has been marked as a duplicate of this bug. *** This is really a critical bug. Michael, let's fix this for 2.1.2. Under what definition of 'critical'? Reverted to normal. The behaviour itself is not even a bug. We'll add an parameter to set that value, but be warned: you may run into timeouts if you set it to a very high value. Not being able to create full diffs at all is critical. You can't create appliable patches and you can not review submissions at all. (In reply to comment #8) > Under what definition of 'critical'? Reverted to normal. The behaviour itself > is not even a bug. > > We'll add an parameter to set that value, but be warned: you may run into > timeouts if you set it to a very high value. Do we run into a timeout if we set the value to 1000? This could solve at least the majority of cases until we have a _real solution_. backend now supports full diff for 2.2, we need to enhance webui and osc for it. (FATE 310489) The webui parts are fixed now. osc should display full diffs now. Commit 2ce8484 in master branch |
I do: osc rdiff -u openSUSE:Factory sysconfig | tail +-$as_echo "$as_me: WARNING: $ac_header: proceeding with the compiler's result" >&2;} +- ac_header_preproc=yes +- ;; +- no:yes:* ) +- { $as_echo "$as_me:$LINENO: WARNING: $ac_header: present but cannot be compiled" >&5 +-$as_echo "$as_me: WARNING: $ac_header: present but cannot be compiled" >&2;} +- { $as_echo "$as_me:$LINENO: WARNING: $ac_header: check for missing prerequisite headers?" >&5 +-$as_echo "$as_me: WARNING: $ac_header: check for missing prerequisite headers?" >&2;} (82 more lines skipped) ie. it appears to give up in the middle of the diff - why ? Apparently there is no obvious option to persuade it to do a full diff; and: $ osc rdiff -u openSUSE:Factory sysconfig | wc -l 261 why 261 ? ;-) is that 256 + 5 or ...