Bug 523192

Summary: yast2-control-center-2.18.5-1.2: missing return statement
Product: [openSUSE] openSUSE 11.2 Reporter: David Binderman <dcb314>
Component: YaST2Assignee: Thomas Göttlicher <tgoettlicher>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None    
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2009-07-17 18:38:37 UTC 
I just had a look at factory package yast2-control-center-2.18.5-1.2
For source code file yast2-control-center-2.18.5/src/yqdesktopfilesmodel.cpp,
around line 199 is the source code

bool YQDesktopFilesModel::removeRow(int row )
{

   QString key = d->desktop_files.value( row );
   qDebug() << "removing empty " << key;
   d->desktop_files.removeAt( row );

   d->cache.remove( key );

}

Clearly broken code. There appears to be a missing return
statement for the bool return type. Suggest add one.
Comment 1 Katarina Machalkova 2009-07-20 08:03:27 UTC 
This is fixed in the newest release (2.18.6)