Bug 523447

Summary: btrfsprogs-0.18-2.10: possible memory leak
Product: [openSUSE] openSUSE 11.2 Reporter: David Binderman <dcb314>
Component: OtherAssignee: Dirk Mueller <dmueller>
Status: RESOLVED DUPLICATE QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P4 - Low CC: chris.mason
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2009-07-20 10:56:47 UTC
I just had a look at factory package btrfsprogs-0.18-2.10

For source code file btrfs-progs-0.18/btrfsck.c,
around line 2058 is the source code for the
function check_extents.

I notice a call to malloc for local variable bits,
but no matching calls to free.

This looks like a memory leak to me. Suggest add a call
to free near the end of the routine.
Comment 1 Dirk Mueller 2009-07-20 16:11:27 UTC
Chris, is this already fixed in a newer version? :)
Comment 2 Dirk Mueller 2009-07-20 21:13:29 UTC
as far as I can see, it is not fixed in 0.19 yet.
Comment 3 Chris Mason 2009-07-22 14:29:03 UTC
We do have a patch pending for it, I'll push it out to the git repo this week.  btrfs-progs v0.20 will be coming out shortly, I also have a fix queued for the converter.
Comment 4 Dirk Mueller 2009-07-24 15:42:06 UTC
Thanks, waiting for 0.20 to resolve this bug.
Comment 5 Dirk Mueller 2009-09-21 11:28:55 UTC
not an exact duplicate, but the 0.20 update should solve both

*** This bug has been marked as a duplicate of bug 537633 ***