Bug 533584

Summary: Misleading wording "Detected printers " if there are no printers
Product: [openSUSE] openSUSE 11.2 Reporter: Forgotten User tCnyPY8iPq <forgotten_tCnyPY8iPq>
Component: YaST2Assignee: Johannes Meixner <jsmeix>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Minor    
Priority: P4 - Low CC: jsmeix
Version: Milestone 6   
Target Milestone: Future 11.3   
Hardware: All   
OS: SUSE Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Forgotten User tCnyPY8iPq 2009-08-23 13:11:26 UTC
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; it; rv:1.9.1.2) Gecko/20090730 SUSE/3.5.2-2.1 Firefox/3.5.2 GTB5 AutoPager/0.5.2.2 (http://www.teesoft.info/)

After the printing detecting process, the message "Detected printers" is shown. In fact there are no printers on my system, so the message shoud be "Printer detection finished" or something like that.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Comment 1 Johannes Meixner 2009-09-09 07:21:43 UTC
Which "printing detecting process" are you talking about?

Could you provide a sceenshot or describe in more detail
when and what happened on your particular system.

Provide at least the YaST logs. As root run
  save_y2logs /tmp/y2logs.tgz
and then attach /tmp/y2logs.tgz to this bug report.

Because you selected the bug component "Installation"
I guess you mean the YaST printer detection during
hardware setup at the end of the system installation.

In this case the code in
/usr/share/YaST2/clients/printer_proposal.ycp
is executed which contains:
------------------------------------------------------------
  if( size(detected_printers) < 1 )
  { ...
    proposal = [ _("No local printer detected.") ];
  }
------------------------------------------------------------
so that you should get the "No local printer detected."
text if there are no printers connected to your system.

For real analysis I need the YaST logs (see above).
Comment 2 Forgotten User tCnyPY8iPq 2009-09-10 12:59:25 UTC
Yes, I was referring to the installation's printer detection.
I looked at that file, and I think the problem is instead in the file «/usr/share/YaST2/modules/Printer.ycp».
This code (found in that file) doesn't seem to check if printer # equals 0 and always displays the "Detected printers" message in the progress window.

I don't know this programming language, so I could be wrong.

-------------BEGIN--------------
  if( progress_feedback )
  { // Setting the DownloadProgress to 100% by setting its property
    // ExpectedSize to 1 results bad looking output (see above).
    // Therefore DownloadProgress is not used at all but replaced by a 100% ProgressBar
    // which requires a MinWidth with sufficient size (see above).
    UI::ReplaceWidget( `id(`autodetect_printers_progress_replace_point),
                       `ProgressBar( // Header for a finished ProgressBar:
                                     _("Detected printers"),
                                     100,
                                     100
                                   )
                     );
    // Sleep half a second to let the user notice that the progress is finished:
    sleep( 500 );
    UI::CloseDialog();
  }
-------------END--------------
Comment 3 Johannes Meixner 2009-09-10 13:28:35 UTC
Now I understand what you mean!
Many thanks to point directly to the right place in the code.

Yes, if no printer is detected, the "Detected printers" text
is misleading and should be replaced by something like
"Printer detection finished".

There should be a message when the printer detection has finished
so that I do not want to omit it but I will use a better wording.

This minor issue will probably not be fixed for openSUSE 11.2
but for the next openSUSE version.
Comment 4 Johannes Meixner 2009-09-23 12:12:06 UTC
To avoid that a changed text is untranslated in openSUSE 11.2
I will fix it not for openSUSE 11.2 but for the
next openSUSE version.
Comment 5 Johannes Meixner 2009-11-10 10:38:05 UTC
In Printer.ycp replaced "Detected printers"
by "Printer detection finished".

Fixed in YaST SVN at revision 59455.