Bug 536207

Summary: procps-3.2.8-3.2: missing call to fclose
Product: [openSUSE] openSUSE 11.2 Reporter: David Binderman <dcb314>
Component: OtherAssignee: Dr. Werner Fink <werner>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Factory   
Target Milestone: ---   
Hardware: All   
OS: openSUSE 11.1   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: procps-3.2.8-fdleak.dif

Description David Binderman 2009-09-02 09:33:47 UTC
I just had a look at factory package procps-3.2.8-3.2

For source code file procps-3.2.8/vmstat.c
around line 420, function slabformat
is the following code

  fSlab=fopen("/proc/slabinfo", "rb");

but I fail to find a matching call to fclose.
This looks like a resource leak to me. Suggest add call
to fclose.
Comment 1 Dr. Werner Fink 2009-09-10 08:15:47 UTC
Created attachment 317550 [details]
procps-3.2.8-fdleak.dif

Curious ... but I feel like a waste basket ;)
David?  Why do you not report upstream?
Comment 2 Dr. Werner Fink 2009-09-10 08:25:31 UTC
Added patch
Comment 3 David Binderman 2009-09-10 18:28:12 UTC
(In reply to comment #1)
> Curious ... but I feel like a waste basket ;)

Non comprendi.

> David?  Why do you not report upstream?

One Novell account, where most (but not all) openSuse
workers fix reported bugs, and file upstream, versus one account 
for each OpenSuse package (3200 or so ?) and I've got to
file each one upstream myself ?

For me, the trade-off is easy, even if a small
percentage of openSuse workers nag me about reporting
upstream ;->