Bug 536209

Summary:	psmisc-22.7-4.2: another missing call to fclose
Product:	[openSUSE] openSUSE 11.2	Reporter:	David Binderman <dcb314>
Component:	Other	Assignee:	Dr. Werner Fink <werner>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None
Version:	Factory
Target Milestone:	---
Hardware:	All
OS:	openSUSE 11.1
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description David Binderman 2009-09-02 09:38:45 UTC

I just had a look at factory package psmisc-22.7-4.2

For source code file psmisc-22.7/src/fuser.c
around line 1630, function scan_knfsd
is the following code

    if ( (fp = fopen(KNFSD_EXPORTS, "r")) == NULL) {

but I fail to find a matching call to fclose.
This looks like a resource leak to me. Suggest add call
to fclose.

Comment 1 Dr. Werner Fink 2009-09-10 08:24:51 UTC

AFAICS from source code the function scan_knfsd() is not used
as the cpp key NFS_CHECKS is not defined.  Nevertheless you
should report this upstream.  Please note that I'm the maintainer
only of psmisc and also of more than 100 packages ... beside
my daily work here.

Sidemark: I've added the missing fclose(fp) in scan_knfsd()
even if it is not used.