Bug 546028

Summary: Kaffeine playback not in device actions for a Video DVD
Product: [openSUSE] openSUSE 11.4 Reporter: Axel Braun <axel.braun>
Component: KDE4 WorkspaceAssignee: E-mail List <kde-maintainers>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: forgotten_kHYb7eJGnH, forgotten_vXTZVacoSi, giecrilj, jim.sublette
Version: RC 1   
Target Milestone: RC 1   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Axel Braun 2009-10-11 13:16:13 UTC
User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.3; Linux) KHTML/4.3.1 (like Gecko) SUSE

When inserting a video-DVD, 'open with filemanger' and 'download pictures with digikam' are proposed activities, but not 'play DVD with kaffeine'.

Actually, this is as well not working on 11.1 with KDE 4.3.1 - the settings in 'Geräteaktionen' (device activities?) for 'Play DVD with kaffeine' seem not to work. 

No idea where to look up the 'available content' for the 'optical disk', which is currently set to 'VideoDvd' (but not working properly). This makes the system settings dialog pretty unusable

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Comment 1 Axel Braun 2009-10-25 18:37:05 UTC
Problem still exists in 11.2RC1
Comment 2 Axel Braun 2010-01-07 08:03:30 UTC
..and in 11.2 final with KDE 4.3.4 as well. Upstream problem?
Comment 3 Forgotten User kHYb7eJGnH 2010-02-22 06:13:39 UTC
https://bugs.kde.org/show_bug.cgi?id=173388 seems to be it. Saying fixed at 4.4

In 4.4 there is a settings area for device notifier and it includes a pre-set setting for play DVD with Kaffeine
Comment 4 Axel Braun 2010-02-22 07:42:43 UTC
(In reply to comment #3)
> https://bugs.kde.org/show_bug.cgi?id=173388 seems to be it. Saying fixed at 4.4
> 
> In 4.4 there is a settings area for device notifier and it includes a pre-set
> setting for play DVD with Kaffeine

The settings dialog from 4.3 is not embedded in the device notifier, and it contains an activity for 'play DVD'. But this activity is not associated with an inserted DVD, so there must be a mismatch.
But as long as you dont have any documentation about possible settings, or a toll that shows you as what a DVD was identified, it is fairly impossible to get it up and running....
Comment 5 Axel Braun 2010-02-24 21:33:13 UTC
After I found this useful article
http://www.linux-community.de/Internal/Artikel/Online-Artikel/Die-Geraeteueberwachung/%28article_body_offset%29/2
I could dig into it a little deeper.
As an example:
axel@z60m:~> solid-hardware details '/org/freedesktop/Hal/devices/volume_label_SHREK_THE_HALLS'
udi = '/org/freedesktop/Hal/devices/volume_label_SHREK_THE_HALLS'
  parent = '/org/freedesktop/Hal/devices/storage_model_DVD_RAM_UJ_830Sx'  (string)
  vendor = ''  (string)
  product = 'SHREK_THE_HALLS'  (string)
  Block.major = 11  (0xb)  (int)
  Block.minor = 0  (0x0)  (int)
  Block.device = '/dev/sr0'  (string)
  StorageAccess.accessible = false  (bool)
  StorageAccess.filePath = ''  (string)
  StorageVolume.ignored = false  (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'udf'  (string)
  StorageVolume.label = 'SHREK_THE_HALLS'  (string)
  StorageVolume.uuid = ''  (string)
  StorageVolume.size = 3257440256  (0xc2289800)  (qulonglong)
  OpticalDisc.availableContent = 'Data|VideoDvd'  (0x12)  (flag)
  OpticalDisc.discType = 'CdRecordable|CdRewritable|DvdRom'  (0x3)  (enum)
  OpticalDisc.appendable = false  (bool)
  OpticalDisc.blank = false  (bool)
  OpticalDisc.rewritable = false  (bool)
  OpticalDisc.capacity = 3257440256  (0xc2289800)  (qulonglong)

is a DVD, and no kaffeine-Entry is offered.

Taking a look at /usr/share/kde4/apps/solid/actions/kaffeine_play_dvd, it contains
X-KDE-Solid-Predicate=[ StorageVolume.ignored == false AND OpticalDisc.availableContent == 'VideoDvd' ]
..this does of course not match. Changing the 'avail. content' from 'equal' to 'contains', it does not work eiher.

Why not? No idea. I would expect an entry in ~/.kde4/share/apps/solid/actions, if the user modifies these settings, but there is no such entry. Where does it go?
Comment 6 Axel Braun 2010-02-24 21:39:02 UTC
Update: Changing the content of  /usr/share/kde4/apps/solid/actions/kaffeine_play_dvd to 

X-KDE-Solid-Predicate=[ StorageVolume.ignored == false AND
OpticalDisc.availableContent & 'VideoDvd' ]
makes it work.
So we have a workaround, but the user should be able to do this by himself in the system settings. This is clearly not working in KDE: 4.4.00 (KDE 4.4.0) "release 222"
Comment 7 Forgotten User kHYb7eJGnH 2010-03-08 11:01:01 UTC
Updated status to 11.2 final
Comment 8 Axel Braun 2010-05-07 09:33:23 UTC
Just updated to 4.4.3 and see still the wrong entries in /usr/share/kde4/apps/solid/actions/kaffeine_play* - means it will also be an issue in openSUSE 11.3.

Can one please fix this upstream?
Comment 9 Christopher Yeleighton 2010-09-13 14:59:28 UTC
It is already fixed upstream, and the culprit is your patch [1].  So your job is now to identify the "plasma start-up error", disable this "amendment" and see if the hypothetical error still occurs.  If it does, find another way to fix it, because it is a serious usability problem the way it is now.
Of course, there is a user-level and a local-level workaround as well.
___
[1] <URL:file:///usr/src/packages/SOURCES/fix_plasma_startup_error.diff>
Comment 10 Axel Braun 2010-09-15 09:36:28 UTC
(In reply to comment #9)
> It is already fixed upstream, and the culprit is your patch [1].  

Not sure to understand you completely. First, I cant see you local file, second, I have no idea what you want from me....
Comment 11 Christopher Yeleighton 2010-09-15 15:45:23 UTC
{ zypper source-install kaffeine; } will do the trick.

Here is an excerpt from kaffeine.spec:

Patch1:         fix_plasma_startup_error.diff

I want you to remove that line or comment it out.
Comment 12 Axel Braun 2010-09-15 16:50:46 UTC
(In reply to comment #11)
> { zypper source-install kaffeine; } will do the trick.

..or looking at the spec-file in the buildservice.

> Here is an excerpt from kaffeine.spec:
> 
> Patch1:         fix_plasma_startup_error.diff
> 
> I want you to remove that line or comment it out.

I did not put it in, maybe you ask the maintainers of kaffeine , e.g. Jürgen Kofler.
looks like the patch reverses my proposal from comment #6
Comment 13 Christopher Yeleighton 2010-09-16 11:47:14 UTC
Jürgen Kofler!  Please be so kind and remove this patch!  Thanks!
Comment 14 Christopher Yeleighton 2010-09-17 15:44:15 UTC
Oops, Jürgen Kofler is not the mainteiner of Kaffeine.  Assigned to Stephan Binner because I found his address in the change log.  Hope this helps.
Comment 15 Forgotten User vXTZVacoSi 2011-02-20 20:02:38 UTC
I doubt it as he doesn't work for suse anymore.

X-KDE-Solid-Predicate=OpticalDisc.availableContent & 'VideoDvd' is in /usr/share/kde4/apps/solid/actions/kaffeine_play_dvd which sounds like it should work according to comment #6

Also it shows kaffeine in the device notifier now on a dvd.


(changed during the 2011-02-20 Open-Bugs-Day about bugs for obsolete versions of openSUSE)