Bug 548463

Summary:	N-trig driver is obsolete
Product:	[openSUSE] openSUSE 11.1	Reporter:	Daniel FAIVRE <geomaticien>
Component:	Kernel	Assignee:	Jiri Kosina <jkosina>
Status:	RESOLVED WONTFIX	QA Contact:	E-mail List <qa-bugs>
Severity:	Major
Priority:	P3 - Medium	CC:	amanpreet.alam
Version:	Final
Target Milestone:	Final
Hardware:	All
OS:	All
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	patch

Description Daniel FAIVRE 2009-10-20 15:44:31 UTC

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; fr; rv:1.9.0.14) Gecko/2009090900 SUSE/3.0.14-0.1.2 Firefox/3.0.14

N-trig driver is obsolete in kernels < git-2.6.32

This applies to all current OpenSuSE kernels.


Reproducible: Always

Steps to Reproduce:
1. Install OpenSuSE on a laptop with n-trig touchscreen, like HP tx2-xxxx
2. Test touchscreen with wacdump (either from linuxwacom or from packman)

(Note : linuxwacom must be patched to recognize 1b96 vendor's devices)

Actual Results:  
N-trig touchscreens do not work.

Expected Results:  
Touchscreen should work "out-of-the-box" when installing OpenSuSE on computers with this device.

Rafi Rubin suggested to replace hid-ntrig.c by the last version from git to solve this issue.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=drivers/hid/hid-ntrig.c;hb=HEAD

That works.

So please include the last version of hid-ntrig.c in any new OpenSuSE kernel release.

Comment 1 Stefan Dirsch 2009-10-25 03:23:14 UTC

So these are the commits, which are still missing in our kernel:

commit a24f423bdf253ccee369adc6c5451b40a0716fbb
Author: Peter Huewe <peterhuewe@gmx.de>
Date:   Thu Jul 2 19:08:38 2009 +0200

    HID: adding __init/__exit macros to module init/exit functions
    
    Trivial patch which adds the __init and __exit macros to the module_init /
    module_exit functions of several HID drivers from drivers/hid/
    
    Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>

commit 837b47533a6476ab3fb96b1f52edd3ce9f3162b8
Author: Rafi Rubin <rafi@seas.upenn.edu>
Date:   Tue Jun 23 14:09:26 2009 -0400

    HID: ntrig tool separation and pen usages
    
    When both touch and pen are active send a tool announcement before
    sending any status changes so that event users may differentiate
    which tool is changing.
    
    Restored three usage codes used by the pen.
    
    Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
    Acked-by: Stephane Chatty <chatty@enac.fr>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Comment 2 Stefan Dirsch 2009-10-25 03:36:10 UTC

Created attachment 324021 [details]
patch

The patch.

Comment 3 Jiri Kosina 2009-11-04 14:46:42 UTC

OpenSUSE 11.1 is based on 2.6.27 kernel, which is lacking the infrastructure (HID bus) that is necessary for the n-trig driver as-is in newer kernels; therefore simple update is not easily possible, it will require drastic changes in core of the HID code, which are not possible at this stage.

openSUSE 11.2 will have the up-to-date n-trig driver included automatically.