Bug 549944

Summary: autoyast module untranslated string "image deployment"
Product: [openSUSE] openSUSE 11.2 Reporter: Kalman Kemenczy <kkemenczy>
Component: YaST2Assignee: Katarina Machalkova <kmachalkova>
Status: RESOLVED FIXED QA Contact: Jiri Srain <jsrain>
Severity: Normal    
Priority: P5 - None CC: ke
Version: RC 1   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: autoyast - image deployment

Description Kalman Kemenczy 2009-10-25 21:46:34 UTC
Created attachment 324045 [details]
autoyast - image deployment

please find the attached screenshot
Comment 1 Katarina Machalkova 2009-11-06 16:53:46 UTC
I think I know how to fix this, rpmlint told me ;)

deploy_images.desktop is part of yast2-installation, but as it is not placed into standard YaST .desktop files location (/usr/share/applications/YaST2), the directive to process it with suse_update_desktop_files script is not placed into y2-installation.spec by default. It has to be added into .spec manually, so that strings from .desktop have a chance to get collected and translated

(rpmlint complains that y2-installation contains .desktop file but does not process it with suse_update_desktop_files)
Comment 3 Katarina Machalkova 2010-02-22 11:19:18 UTC
This is now fixed for SLE11 SP1 by adding one more loop with %suse_update_desktop_file to traverse _datadir/autoinstall/modules

But for 11.3, I'd think about more systematic solution. As far as .desktops are concerned, y2-devtools unwinds @INSTALL@ macro like this:

for f in `find $RPM_BUILD_ROOT/%{prefix}/share/applications/YaST2/ -name "*.desktop"` ; do
    d=${f##*/}
    %suse_update_desktop_file -d ycc_${d%.desktop} ${d%.desktop}
done

Could the directory expression to 'find' be more generic? %{buildroot}%{_datadir}/ is maybe too generic, but I've no other idea atm. 

We need to cover _datadir/share/applications/YaST2/ and _datadir/autoinstall/modules locations with .desktops basically

Martin, what do you think?
Comment 4 Martin Vidner 2010-02-22 12:02:47 UTC
Fortunately "find" accepts multiple paths as starting points for the search, so we can just say
  for f in `find $RPM_BUILD_ROOT/%{prefix}/share/applications/YaST2 $RPM_BUILD_ROOT/%{prefix}/share/autoinstall/modules -name
"*.desktop"` ; do ...
Comment 5 Katarina Machalkova 2010-03-12 12:23:24 UTC
ENOTIME for yast2-devtools hacking :(
I've deployed the same solution as in SLE11 SP1